[chrispader]

Privileged PGO preview jobs need trusted physical runners and repository build secrets. This draft retains the earlier preview prototype and inherits the iOS instrumentation and proof fixes. It also opts deployments into optimized release builds, so it is outside the report-only merge plan at margelo#32.

Release PGO training needs signed-in physical devices and build secrets, which a PR from the Margelo fork cannot access in Expensify/App. This draft brings the native PGO work to Expensify main for review and adds a workflow for a trusted branch inside Expensify/App. Once a maintainer mirrors this branch there and opens a same-repository PR, each push will train a profile, build Release artifacts, and run paired benchmarks without submitting an app to a store.

Explanation of Change

The inherited iOS corrections cover compatible IR instrumentation, explicit Swift frontend flags, Rock argument quoting and sealed IPA proof verification before upload. Local iOS verification was a build/profile/startup smoke on a pinned precursor snapshot; it was not a paired performance benchmark or a GitHub Actions/store-export run.

The preview calls the Android and iOS Release build jobs with PGO and benchmarking enabled. It uploads the build proof and benchmark CSV files with a reduced manifest that excludes the account email and device ID. Ordinary PR builds keep their existing runners; the deploy workflow explicitly opts into PGO so its Release behavior remains the same.

The preview runs only when the PR head is @chrispader/perf/pgo-ci-preview in Expensify/App. This fork PR cannot run the privileged preview. The physical-device runners and approved account fixture still need to be provisioned, and production promotion still needs a proof gate before this work is ready to merge. The existing Margelo CI draft is margelo#31.

Fixed Issues

$ #98008
PROPOSAL: #98008

The tracking issue contains the proposal. Formal proposal approval remains pending.

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14046

Tests

1. Mirror the reviewed preview branch into Expensify/App and open a PR to main. Verify that Android and iOS preview jobs start when the PR opens and after each push to that branch.
2. On provisioned runners signed into the approved high-traffic account, verify that each job completes three training journeys, builds a Release artifact, and uploads a matching PGO proof.
3. Verify that each platform uploads benchmark samples for the short and heavy journeys in both build orders. Check that the uploaded manifest omits the account email and device ID.
4. Sign out of a training device and repeat the PR build. Verify that training stops before the Release artifact is built. Check the app log for unexpected JavaScript errors after a successful run.

• Verify that no errors appear in the JS console

Offline tests

1. Disconnect a training device and repeat the PR build. Verify that the journey fails and no Release artifact is uploaded.
2. Restore connectivity before repeating the successful path.

QA Steps

This PR changes native build infrastructure only. QA cannot verify that the profile was applied to a native binary through the staging app UI, so the title carries the No QA prefix.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

No app UI changes are included. Screenshot preference is pending.

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️