[Krishna2323]

Explanation of Change

Fixed Issues

$ #101898
PROPOSAL:

Tests

Setup: sign in as an admin of a Collect or Control workspace with at least 4 members in
assorted roles (admin, member, auditor). Open Workspaces > [workspace] > Members in a
maximized browser window.

The bar replaces the header dropdown

1. Verify the header shows Invite member and a More dropdown, and no selection UI.
2. Select one member with its row checkbox.
3. Verify a dark floating bar slides up from the bottom of the members list, reading 1 selected.
4. Verify the header still shows Invite member and More, and does not swap to a
   "1 selected" dropdown.
5. Select two more members.
6. Verify the bar reads 3 selected and the count does not make the bar jump in width.
7. Press the X at the right of the bar.
8. Verify every row is deselected and the bar disappears.

Actions in the bar

9. Select one member (role: member).
10. Verify the bar shows up to three action buttons, and a More button when the selection
    supports more actions than that.
11. Press More.
12. Verify a menu opens above the bar listing the remaining actions, and that the menu is dark
    like the bar rather than the page.
13. Verify the actions offered across the buttons and the menu match what the old header dropdown
    offered for that selection: Remove member, Make admin, Make auditor,
    Make card admin (Control only), and no Make member for a member.
14. Press Make admin.
15. Verify the member's role changes to Admin, the selection clears, and the bar disappears.
16. Select two members and press Remove members.
17. Verify the confirmation modal appears, and that confirming removes both members.

Keyboard

18. Select a member by clicking its row checkbox, then press Esc.
19. Verify the selection clears, the bar disappears, and you stay on the Members page.
20. Press Esc again with nothing selected.
21. Verify you navigate back out of the workspace, as before this PR.
22. Click the select all checkbox in the table header, then press Esc.
23. Verify the selection clears and no blue focus ring is left on the select all checkbox.

Layout

24. Select a member, then scroll the members list to the very bottom.
25. Verify the last row scrolls clear of the bar rather than sitting behind it.
26. With a selection active, narrow the window to a medium width (roughly 800-1000px).
27. Verify the bar is still shown, now with fewer action buttons and the rest behind More.
28. Narrow the window further, to a mobile width.
29. Verify the bar is gone and the page falls back to the existing mobile selection mode, with the
    N selected dropdown in the header.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline.
2. Select two members and use the bar to change their role.
3. Verify the rows show the pending (greyed) state and the selection clears, matching the behaviour
   of the old header dropdown.
4. Go back online and verify the change is saved.

QA Steps

• Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_hybrid.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web_chrome.mp4

[melvin-bot]

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[dylanexpensify]

Looks good from a product perspective 👍

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	95.90% <ø> (ø)
src/CONST/runtimeConfigured.ts	100.00% <ø> (ø)
src/CONST/runtimeDefaults.ts	100.00% <ø> (ø)
src/ONYXKEYS.ts	100.00% <ø> (ø)
src/SCREENS.ts	100.00% <ø> (ø)
...c/components/BulkActionBar/BulkActionBarButton.tsx	73.52% <100.00%> (+73.52%)	⬆️
src/components/BulkActionBar/index.tsx	79.24% <100.00%> (+79.24%)	⬆️
...ulkActionBar/useBulkActionBarFocus/index.native.ts	100.00% <100.00%> (ø)
src/components/Button/Button.tsx	100.00% <ø> (ø)
...rc/components/Icon/chunks/expensify-icons.chunk.ts	0.00% <ø> (ø)
... and 23 more
... and 11 files with indirect coverage changes

[Krishna2323]

@MelvinBot review

[MelvinBot]

Review

The approach looks right: the bar is driven by the table's controlled selection, so the bar, the page's selectedEmployees, and the list padding stay in sync. There is one blocker and one accessibility gap to fix before this is ready.

1. CI is red because the new copy exists only in en.ts (blocker).
typecheck fails with Property 'bulkActionBar' is missing in every other locale, and TranslateTest › Does es locale have all the keys fails. Add bulkActionBar.label, clearSelection, and loadingSelection to the other src/languages/*.ts files. You can run npx bun ./scripts/generateTranslations.ts locally or ask an employee to run the translation workflow.

2. Pressing an action drops focus to <body>.
types.ts:5 says to call handleFocusBeforeClose "from every path that clears the selection." Only Esc and the X button call it (index.tsx:104). An inline action runs option.onSelected (BulkActionBarButton.tsx:71). For example, Make admin runs changeUserRole, which clears the selection. The bar then unmounts while its own button still has focus. A keyboard user lands on <body> and has to tab from the top of the page. Picking an item from More ends the same way after the popover returns focus to the More button. To fix this, move focus off the bar when selectedCount drops to 0 while focus is inside it, for example in an effect or an unmount cleanup in useBulkActionBarFocus. That covers every path, not only the paths the bar controls.

Minor points

• Scope: Moving SelectionToolbar in MoneyRequestReportActionsList.tsx:309 / :361 is outside the linked members-table issue. Because the toolbar now renders in two different tree positions, crossing the breakpoint remounts it. That resets its local state, such as an open download-error DecisionModal or the duplicate handler. Consider splitting this into its own PR, or keep it and note it in the description.
• Shared behavior change: captureOnInputs: false, the Enter guard, and the new announcement apply to every BulkActionBar consumer, including Search and the report view. The Esc change is reasonable, but please add Search and report view to the test steps so QA covers them.
• Test coverage: The rewritten tests no longer assert shouldPopoverUseScrollView for the long option list. Also, openBulkActions returns silently when no More button is found. The not.toBeOnTheScreen() checks only mean something because each test also makes a positive assertion.
• PR description: Explanation of Change and PROPOSAL are empty.

[dannymcclain]

Video is looking good, but @Expensify/design I still feel like we need to update this to consolidate all those Make {role} options. Why not just do something like this with a Change role button that opens up the role selector?

[dubielzyk-expensify]

Oh I waaay prefer that. Great call 👍

[shawnborton]

Same!

[Krishna2323]

Failing check is on main

[Krishna2323]

@shubham1206agra friendly bump

[shubham1206agra]

@Krishna2323 Fix tests please