Skip to content

Add bulk update start date for Company Card - #102121

Merged
marcochavezf merged 34 commits into
Expensify:mainfrom
hungvu193:feat-bulk-transaction-startDAte
Oct 23, 2026
Merged

marcochavezf merged 34 commits into
Expensify:mainfrom
hungvu193:feat-bulk-transaction-startDAte

Conversation

@hungvu193

@hungvu193 hungvu193 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Add Bulk Edit Transaction Start Date for Company Cards

Fixed Issues

$ #101355
PROPOSAL: N/A

Tests

Prerequisite:

  • Your workspace has Company Cards with several cards assigned to you.
  1. Go to Company Cards > Select some cards > Update transacton card date.
  2. Try to update the date.
  3. Verify that you can update the date.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-10-12.at.13.34.16.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-10-12.at.11.53.31.mov
iOS: mWeb Safari
Screen.Recording.2026-10-12.at.11.41.55.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-24.at.13.19.37.mov
Screen.Recording.2026-10-12.at.11.35.45.mov

@melvin-bot

melvin-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 95.90% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
...nts/Avatar/connected/AccountAvatarWithCardFeed.tsx 100.00% <ø> (ø)
...ponents/Avatar/layouts/SubscriptCardFeedAvatar.tsx 100.00% <ø> (ø)
...on/shouldUseExplicitBottomPosition/index.native.ts 100.00% <100.00%> (ø)
src/components/SupportTicketResolvedFooter.tsx 0.00% <ø> (ø)
...ompanyCardsTable/WorkspaceCompanyCardsTableRow.tsx 0.00% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
src/libs/Navigation/OnyxTabNavigator.tsx 84.84% <ø> (ø)
src/libs/Navigation/linkingConfig/OldRoutes.ts 100.00% <ø> (ø)
... and 22 more
... and 720 files with indirect coverage changes

@hungvu193

hungvu193 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author

Note

Check the case when the user chooses 1 card - should we reuse the existing page instead new bulk edit page?
Handle the update card failed case (RBR on table row).

@hungvu193
hungvu193 force-pushed the feat-bulk-transaction-startDAte branch from 70ee532 to 6893edc Compare October 12, 2026 03:48
@hungvu193
hungvu193 marked this pull request as ready for review October 12, 2026 06:29
@hungvu193
hungvu193 requested review from a team as code owners October 12, 2026 06:29
@melvin-bot
melvin-bot Bot requested review from Eskalifer1 and joekaufmanexpensify and removed request for a team and joekaufmanexpensify October 12, 2026 06:29
@melvin-bot

melvin-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 12, 2026 06:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T09:10:00.162843Z 3790d21 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/components/GrowlNotification/GrowlNotificationContent.tsx Outdated

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my perspective.

@Eskalifer1

Copy link
Copy Markdown
Contributor

@hungvu193 Seems like we have merge conflicts

@hungvu193

Copy link
Copy Markdown
Contributor Author

All yours @marcochavezf 😄

@marcochavezf

Copy link
Copy Markdown
Contributor

Conflicts 😢

@hungvu193

Copy link
Copy Markdown
Contributor Author

@marcochavezf Resolved 😄

marcochavezf
marcochavezf previously approved these changes Oct 22, 2026
@hungvu193

Copy link
Copy Markdown
Contributor Author

@marcochavezf I guess we can merge it? 😄

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

Do we not need to resolve the failing test? @hungvu193

@hungvu193

Copy link
Copy Markdown
Contributor Author

Do we not need to resolve the failing test? @hungvu193

That's the issue with github action, I believe it's not related.

@hungvu193

Copy link
Copy Markdown
Contributor Author

@MelvinBot Can you help rerun the Validate Github Actions?

@MelvinBot

Copy link
Copy Markdown
Contributor

I couldn't rerun it. My token gets a 403 when it tries to rerun workflow runs. A rerun likely wouldn't help anyway, because this failure isn't flaky.

The verify job failed with:

Error: Diff found when Github Actions were rebuilt. Did you forget to run npm run gh-actions-build...

This PR changes two compiled action files that look unrelated to the feature:

  • .github/actions/javascript/isDeployChecklistLocked/index.js
  • .github/actions/javascript/proposalPoliceComment/index.js

To fix it, use one of these options:

  1. Revert both files to match main.
  2. Merge main, then run npm run gh-actions-build after a clean install, and commit the result.

view run

@hungvu193

Copy link
Copy Markdown
Contributor Author

I accidentally pushed github action files, fixed.

@marcochavezf
marcochavezf merged commit 8068bcf into Expensify:main Oct 23, 2026
36 of 37 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.5.20-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

A help site update is needed. I opened a draft docs PR: Docs updates for E/A#102121 Add bulk update option for company card transaction start date.

This PR adds a new user-facing bulk action that isn't behind a beta. Admins can now select several assigned cards on the Company cards page and choose Update transaction start date from the selection bar.

The docs PR adds one sentence to the FAQ in Assign Company Cards. Before, that answer only described the single-card path:

Yes. You can update the Transaction start date at any time from the assigned card's details.

I took the label from src/languages/en.ts.

@hungvu193, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #104950 was identified to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants