Repository navigation
Add bulk update start date for Company Card - #102121
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Note Check the case when the user chooses 1 card - should we reuse the existing page instead new bulk edit page? |
70ee532 to
6893edc
Compare
|
@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good from my perspective.
|
@hungvu193 Seems like we have merge conflicts |
|
All yours @marcochavezf 😄 |
|
Conflicts 😢 |
|
@marcochavezf Resolved 😄 |
|
@marcochavezf I guess we can merge it? 😄 |
|
Do we not need to resolve the failing test? @hungvu193 |
That's the issue with github action, I believe it's not related. |
|
@MelvinBot Can you help rerun the Validate Github Actions? |
|
I couldn't rerun it. My token gets a 403 when it tries to rerun workflow runs. A rerun likely wouldn't help anyway, because this failure isn't flaky. The
This PR changes two compiled action files that look unrelated to the feature:
To fix it, use one of these options:
|
|
I accidentally pushed github action files, fixed. |
|
🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.5.20-0 🚀
|
|
A help site update is needed. I opened a draft docs PR: Docs updates for E/A#102121 Add bulk update option for company card transaction start date. This PR adds a new user-facing bulk action that isn't behind a beta. Admins can now select several assigned cards on the Company cards page and choose Update transaction start date from the selection bar. The docs PR adds one sentence to the FAQ in Assign Company Cards. Before, that answer only described the single-card path:
I took the label from @hungvu193, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #104950 was identified to be related to this PR. |
Explanation of Change
Add Bulk Edit Transaction Start Date for Company Cards
Fixed Issues
$ #101355
PROPOSAL: N/A
Tests
Prerequisite:
Offline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-10-12.at.13.34.16.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-10-12.at.11.53.31.mov
iOS: mWeb Safari
Screen.Recording.2026-10-12.at.11.41.55.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-24.at.13.19.37.mov
Screen.Recording.2026-10-12.at.11.35.45.mov