[Insights: Violations][R2]: Add the date filter any-approval by nkdengineer · Pull Request #101058 · Expensify/App

nkdengineer · 2026-09-14T08:24:37Z

Explanation of Change

Auth already accepts anyApproval for type:expense (alongside has:approved-violation or violationApprover), but App had no way to express that date range. This PR wires the key end to end the same way approved is wired: parser, autocomplete, advanced filters, and query round-trip. It is expense-only, and the date picker does not offer never because every matching expense has an approval action.

Fixed Issues

$ #99930
PROPOSAL:

Tests

Open the advanced filters and verify "Any approval" appears with a date picker, set it to last month, and verify the query text reads any-approval:last-month
Type any-approval: or anyApproval: in the search bar and verify the date presets autocomplete
Verify the results only include expenses approved or forwarded in the period

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-10-16.at.20.27.07.mov

Android: mWeb Chrome

Screen.Recording.2026-10-16.at.20.22.43.mov

iOS: Native

Screen.Recording.2026-10-16.at.20.27.46.mov

iOS: mWeb Safari

Screen.Recording.2026-10-16.at.20.24.02.mov

MacOS: Chrome / Safari

Screen.Recording.2026-10-16.at.20.20.32.mov

melvin-bot · 2026-09-14T08:24:42Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-09-14T08:28:44Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
src/hooks/useAdvancedSearchFilters.ts	`97.29% <ø> (ø)`
src/hooks/useAutocompleteSuggestions.ts	`73.07% <100.00%> (ø)`
src/libs/SearchParser/autocompleteParser.js	`59.82% <ø> (+0.34%)`	⬆️
src/libs/SearchUIUtils.ts	`73.41% <100.00%> (+<0.01%)`	⬆️
src/types/form/SearchAdvancedFiltersForm.ts	`100.00% <ø> (ø)`
src/libs/SearchAutocompleteUtils.ts	`63.18% <0.00%> (-0.32%)`	⬇️
src/libs/SearchParser/searchParser.js	`85.59% <95.05%> (+0.11%)`	⬆️
... and 47 files with indirect coverage changes

melvin-bot · 2026-09-24T05:51:13Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2026-09-25T07:54:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: HybridApp

ios.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-29.at.16.58.48.mov

daledah · 2026-09-25T09:07:49Z

@neil-marcellini could you please help to run the Generate static translations GitHub workflow here?

daledah · 2026-09-29T03:02:19Z

@nkdengineer please resolve conflict

nkdengineer · 2026-09-29T03:46:33Z

Done.

nkdengineer · 2026-10-02T13:19:22Z

@neil-marcellini I updated the test steps and screen recording on web.

nkdengineer · 2026-10-02T13:23:46Z

Test is failing on main.

neil-marcellini

AI has pointed out some problems relating to some of our existing limitations for using multiple filters. I'm sorry this is getting so messy. I started thinking more about it, and I think this limitation that we must have the has:approved-violation filter to use the any approval filter is overly restricting and unnecessary. I actually think that we should hold this until we fix the backend and remove the restriction. Here's the issue for it [Insights: Violations][R2] Allow the any-approval date filter without restrictions.

You should be able to revert this PR to the commit before I brought up handling the restriction and the tooltip.

Here's the problem I'm talking about with the PR currently that AI found. Due to limitations with multiple filters that we don't plan on changing, I don't think there's a great solution and it would be better to remove the restriction.

(Neil's AI agent)

The auto-applied Has value means AND in one path and OR in the other

Observed (I ran both paths in a throwaway jest test at the PR head):

Typed type:expense has:receipt any-approval:last-month becomes ... has:receipt anyApproval:last-month has:approved-violation. applyRequiredApprovedViolationToQuery appends a separate has: term, which Auth ANDs.
Loading that query into the form gives has: ['approved-violation']. receipt is gone, because buildFilterFormValuesFromQuery overwrites filtersForm.has for each has group, so the last one wins. Rebuilding from the form gives has:approved-violation anyApproval:last-month.
From the form (filter bar or advanced filters), Has = Receipt + any-approval becomes has:receipt,approved-violation via ensureHasApprovedViolation. The PR's own test expects this.

Failure scenarios:

Filter bar: Any approval = last month, Has = Receipt (approved-violation is locked on). Results include every expense with a receipt from any date, plus approved-violation expenses from last month.
Typed has:receipt any-approval:last-month gives correct results at first. The Has chip shows only "Approved violation". Changing any other filter from the bar drops has:receipt without telling the user.

neil-marcellini

(Neil's AI agent, human reviewed)

The last conflict merge kept an old Mobile-Expensify pointer. This PR now moves it from 01c8999 (9.5.13-0, on main) back to c15d05c (9.5.7-3). Can you reset it to main's pointer? For example git checkout origin/main -- Mobile-Expensify (or git update-index --cacheinfo 160000,01c8999192c60d2883b6a93e8c28d4b9ee9db7af,Mobile-Expensify) and commit, so Mobile-Expensify no longer shows in the PR diff.

nkdengineer · 2026-10-16T14:39:51Z

@codex Review.

chatgpt-codex-connector · 2026-10-16T14:40:14Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T15:14:18.202934Z	`0de149b`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b713c2518b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

nkdengineer · 2026-10-16T14:59:40Z

@codex review

chatgpt-codex-connector · 2026-10-16T15:14:16Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 0de149b70d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

neil-marcellini

Great work thanks!

github-actions · 2026-10-16T16:19:57Z

🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-16T16:34:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #101058.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2486be4-14fc833-9ad60be4984cb6f322fe174f439e82d7966251be/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2486be4-14fc833-b95dfb41f34d5aed03b8f7f7f4cd6dba5c884447/index.html

Web 🕸️
https://101058.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-19T17:52:33Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.14-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-10-20T19:17:26Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.14-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

feat: Add the date filter any-approval

923f5f7

melvin-bot Bot assigned nkdengineer Sep 14, 2026

nkdengineer added 8 commits September 18, 2026 15:09

resolve conflict

f71c7cc

regenerate parser

3bd09a6

resolve conflict

583120e

fix test

498967a

Merge branch 'main' into fix/99930

dca6ed3

update query sent to backend

f90a8a9

fix typescript error

84070bd

fix test

86f7f8a

nkdengineer marked this pull request as ready for review September 24, 2026 05:51

nkdengineer requested review from a team as code owners September 24, 2026 05:51

melvin-bot Bot requested review from daledah and removed request for a team September 24, 2026 05:51

melvin-bot Bot requested review from flaviadefaria and removed request for a team September 24, 2026 05:51

github-actions Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread src/hooks/useAutocompleteSuggestions.ts

refactor code

fa6fbae

daledah reviewed Sep 25, 2026

View reviewed changes

Comment thread src/hooks/useAutocompleteSuggestions.ts Outdated

nkdengineer added 2 commits September 28, 2026 12:25

Merge branch 'main' into fix/99930

47f64bb

refactor code

e3aada3

resolve conflict

85db86e

neil-marcellini requested changes Oct 2, 2026

View reviewed changes

neil-marcellini changed the title ~~[Insights: Violations][R2]: Add the date filter any-approval~~ [HOLD Expensify 688159][Insights: Violations][R2]: Add the date filter any-approval Oct 2, 2026

Merge branch 'main' into fix/99930

303c99b

nkdengineer force-pushed the fix/99930 branch from 82cfe12 to 303c99b Compare October 5, 2026 09:11

trjExpensify requested review from trjExpensify and removed request for flaviadefaria October 7, 2026 11:24

nkdengineer added 3 commits October 13, 2026 15:50

Merge branch 'main' into fix/99930

d3c0cb9

Merge branch 'main' into fix/99930

d49ecf5

resolve conflict

955f907

nkdengineer changed the title ~~[HOLD Expensify 688159][Insights: Violations][R2]: Add the date filter any-approval~~ [Insights: Violations][R2]: Add the date filter any-approval Oct 16, 2026

neil-marcellini self-requested a review October 16, 2026 13:47

neil-marcellini mentioned this pull request Oct 16, 2026

[Insights: Violations][R2] Offer never for the any-approval date filter #104235

Open

neil-marcellini requested changes Oct 16, 2026

View reviewed changes

Revert unintended Mobile-Expensify submodule change

b713c25

chatgpt-codex-connector Bot reviewed Oct 16, 2026

View reviewed changes

Comment thread tests/unit/SearchParserTest.ts

Comment thread tests/unit/SearchAutocompleteParserTest.ts

Comment thread tests/unit/hooks/useAutocompleteSuggestions.test.ts

update test comment

0de149b

neil-marcellini approved these changes Oct 16, 2026

View reviewed changes

neil-marcellini merged commit 2486be4 into Expensify:main Oct 16, 2026
36 of 37 checks passed

OSBotify mentioned this pull request Oct 19, 2026

Deploy Checklist: New Expensify 2026-10-19 #104377

Closed

74 tasks done

melvin-bot Bot mentioned this pull request Oct 20, 2026

[Due for payment 2026-10-27] [Insights: Violations][R2] Add the date filter any-approval #99930

Open

Conversation

nkdengineer commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 14, 2026

Uh oh!

codecov Bot commented Sep 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Sep 24, 2026

Uh oh!

Uh oh!

daledah commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

daledah commented Sep 25, 2026

Uh oh!

daledah commented Sep 29, 2026

Uh oh!

nkdengineer commented Sep 29, 2026

Uh oh!

nkdengineer commented Oct 2, 2026

Uh oh!

nkdengineer commented Oct 2, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nkdengineer commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

OSBotify commented Oct 19, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nkdengineer commented Sep 14, 2026 •

edited

Loading

codecov Bot commented Sep 14, 2026 •

edited by github-actions Bot

Loading

daledah commented Sep 25, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading