[Due for payment 2026-09-02] Android - Home - Add attachment modal does not open after tapping + when keyboard is opened

@ZhenjaHorbach

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.4.61-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98336
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Other

Action Performed:

Launch Expensify app.
Tap on the field on Concierge prompt box.
Tap + button.

Expected Result:

Add attachment modal will open after tapping + when keyboard is opened.

Actual Result:

Add attachment modal does not open after tapping + when keyboard is opened.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7242767_1787693669647.Screen_Recording_20260826_053305_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7242767

Issue Owner

Current Issue Owner: @ZhenjaHorbach

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/39b86c6994ef1c707af33b033b1e3bbff327f3297e6c145530509d758e5ba35c

You have been assigned to this deploy blocker because you recently merged this PR: #98336

@puneetlath

@puneetlath @ZhenjaHorbach you have been assigned to this deploy blocker because you reviewed the offending PR: #98336

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@adamgrzybowski

@adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #98336

💬 A slack conversation has been started in #expensify-open-source

@adamgrzybowski

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #98336 - "[Home Page] Add Concierge prompt box to home For You section" by @adamgrzybowski (High confidence)
Related Issues: #94497 (the feature request this PR implemented)

Recommendation: ROLL FORWARD

This is an isolated defect in a large, brand-new feature (the "+" attachment button in the Home Concierge prompt box). The fix is a small, well-understood change (dismiss the keyboard before opening the popover menu), so a targeted roll-forward is safer and cheaper than reverting the entire feature PR. Revert remains a viable fallback if a fix can't land quickly.

Assigned: @adamgrzybowski (PR author), @ZhenjaHorbach and @puneetlath (approving reviewers) — all already assigned by Melvin
Labels: No change. DeployBlockerCash is correctly retained (App deploy is blocked by this frontend regression). No DeployBlocker (web) label is present, so nothing to remove.

📋 Detailed Analysis

Evidence

PR [Home Page] Add Concierge prompt box to home For You section #98336 introduced the entire Concierge prompt box feature on the Home "For You" section, including the new files ConciergePromptBox.tsx and useConciergeAttachmentPicker.ts. This is exactly the UI in the reproduction steps ("Tap on the field on Concierge prompt box" → "Tap + button").
The bug reproduces only on staging and is N/A on production because the feature does not exist in production yet. That timeline matches PR [Home Page] Add Concierge prompt box to home For You section #98336 (merged 2026-08-25), the only PR that ships this component.
The reproduction requires the keyboard to be open first (step 2 focuses the composer input), which is precisely the state the new code fails to handle.

Verification

Affected file: src/pages/home/ForYouSection/ConciergePromptBox.tsx — the "+" button and its PopoverMenu.
Confirmed PR [Home Page] Add Concierge prompt box to home For You section #98336's changed-files list includes this file and the supporting useConciergeAttachmentPicker.ts, both newly added by the PR.
The "+" PressableWithoutFeedback onPress handler is at lines 163-167. The Composer input (rendered at lines 218-234) is given no ref, so the component has no way to blur it / dismiss the keyboard.

Root Cause

On Android native (narrow layout), the "+" action PopoverMenu renders as a bottom-docked modal. Opening that modal while the soft keyboard is still visible does not display it reliably — the keyboard must be dismissed first.

The new ConciergePromptBox "+" handler only blurs the button itself, not the focused text input:

onPress={(e) => {
    e?.preventDefault();
    actionButtonRef.current?.blur(); // blurs the "+" button, NOT the composer input
    setIsMenuVisible((prev) => !prev);
}}

Because the Composer never receives a ref, the keyboard stays open when the menu is toggled, so on Android the attachment popover never appears.

Contrast this with the established report-composer pattern this feature was modeled on. In useComposerFocus.ts, onAddActionPressed explicitly blurs the composer input (composerRef.current?.blur()) before the menu is shown, dismissing the keyboard. AttachmentPickerWithMenuItems calls onAddActionPressed() in its "+" handler (lines 468-478) — the ConciergePromptBox omits this step.

Suggested fix

Give the Composer a ref and blur it (dismissing the keyboard) inside the "+" onPress before setIsMenuVisible, mirroring onAddActionPressed in the report composer. This is a small, self-contained change and does not require reverting the feature.

looking into this!

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Same root cause as #99494: the prompt box's buttons sit inside HomePage's ScrollView, which doesn't set keyboardShouldPersistTaps, so while the keyboard is open the first tap only dismisses the keyboard and never reaches the button. One line in src/pages/home/HomePage.tsx fixes both issues and matches FormWrapper/FormScrollView:

                     <ScrollView
                         contentContainerStyle={styles.homePageContentContainer}
                         addBottomSafeAreaPadding
+                        keyboardShouldPersistTaps="handled"
                     >

Taps on empty space still dismiss the keyboard, so nothing else changes.

(Georgia's Agent)

Issue not reproduce using build 9.4.61-1.
Device : iphone 14/26.6 and Samsung a54/android 16

2026-08-26.7.34.10.PM.mp4

ScreenRecording_08-26-2026.19-26-53_1.MP4

Great! The fix worked.

@ZhenjaHorbach

@ZhenjaHorbach

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix Concierge prompt box requiring two taps with keyboard open #99529

If no regressions arise, payment will be issued on 2026-09-02. 🎊

The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Navigation Menu

Repository navigation

[Due for payment 2026-09-02] Android - Home - Add attachment modal does not open after tapping + when keyboard is opened #99479

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

🔍 Investigation Summary

Recommendation: ROLL FORWARD

Evidence

Verification

Root Cause

Suggested fix

7 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2026-09-02] Android - Home - Add attachment modal does not open after tapping + when keyboard is opened #99479

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

applause-bot commented on Aug 25, 2026

melvin-bot commented on Aug 25, 2026

melvin-bot commented on Aug 25, 2026

github-actions commented on Aug 25, 2026

melvin-bot commented on Aug 25, 2026

melvin-bot commented on Aug 25, 2026

MelvinBot commented on Aug 25, 2026

🔍 Investigation Summary

Recommendation: ROLL FORWARD

Evidence

Verification

Root Cause

Suggested fix

7 remaining items

mhawryluk commented on Aug 26, 2026

melvin-bot commented on Aug 26, 2026

grgia commented on Aug 26, 2026

m-natarajan commented on Aug 26, 2026

puneetlath commented on Aug 26, 2026

melvin-bot commented on Aug 26, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions