Skip to content

[Due for payment 2026-10-27] [$1000] Enable the Go Back button by default (flip shouldUseGoBackButton) #96098

Open

Description

@Julesssss

Problem

Once the site refactors are complete, flip shouldUseGoBackButton on FullScreenLoadingIndicator to default-true so every fullscreen loader shows a "Go Back" button after a timeout. This is the step that actually delivers the recoverable error page — it fixes all remaining trapped-user loaders in one change instead of ~66 one-line PRs.

Solution

Blocked on #96093, #96094, #96095, #96096 (the bullet-1 refactors must land first, otherwise the flip draws a stray "Go Back" button on top of headers that already have one).

  • Set the shouldUseGoBackButton default to true in src/components/FullscreenLoadingIndicator.tsx.
  • Remove the now-redundant explicit shouldUseGoBackButton props from the sites that already pass it.
  • Retain an explicit shouldUseGoBackButton={false} on the six auth/transition screens where Go Back is dead or harmful on a cold deep-link start (no history to pop):
    • ValidateLoginPage/index.tsx
    • ValidateLoginPage/index.web.tsx
    • UnlinkLoginPage
    • LogInWithShortLivedAuthTokenPage
    • DelegatorConnectGate
    • LogOutPreviousUserPage — actively harmful, not just dead: Go Back can pop /transition back into the outgoing user's session mid-Onyx.clear()/sign-out.
Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit

Activity

  1. self-assigned this
    on Jul 14, 2026
  2. Julesssss commented on Jul 30, 2026

    @Julesssss
    ContributorAuthor

    Blocked by open PRs

  3. Julesssss commented on Aug 7, 2026

    @Julesssss
    ContributorAuthor

    We're wrapping up the last PRs

  4. 56 remaining items

  5. changed the title [-][Due for payment 2026-10-21] [$175] Enable the Go Back button by default (flip shouldUseGoBackButton)[/-] [+][Due for payment 2026-10-27] [$175] Enable the Go Back button by default (flip shouldUseGoBackButton)[/+] on Oct 20, 2026
  6. melvin-bot commented on Oct 20, 2026

    @melvin-bot

    @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.14-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-27. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  7. Julesssss commented on Oct 21, 2026

    @Julesssss
    ContributorAuthor

    Total: $1000
    @Julesssss please confirm

    Yep agree.

  8. changed the title [-][Due for payment 2026-10-27] [$175] Enable the Go Back button by default (flip shouldUseGoBackButton)[/-] [+][Due for payment 2026-10-27] [$1000] Enable the Go Back button by default (flip shouldUseGoBackButton)[/+] on Oct 21, 2026
  9. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    ⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

  10. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    Upwork job price has been updated to $1000

  11. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on Oct 26, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions