Skip to content

[Due for payment 2026-10-23] [$250] Reports - Expenses from different merchant grouped with same merchant on "Top Merchants" #80823

Open
Open
[Due for payment 2026-10-23] [$250] Reports - Expenses from different merchant grouped with same merchant on "Top Merchants"#80823
Assignees
HiepPPheyjennahaylakchotemallenexpensifyneil-marcellinitruph01
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNot a priority

Description

@lanitochka17
lanitochka17
opened on Jan 28, 2026

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.3.11.0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80672
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

Prerequisite: Account has at least one workspace.

  1. Open the staging.new.expensify.com website.
  2. Open any workspace chat.
  3. Create two manual expenses on the same report with different merchants (For example: I and Ig) and date from last month.
  4. Navigate to "Reports" > "Top Merchants"
  5. Expand expenses from both merchants.
  6. Note that both expenses are displayed grouped by same merchant and one of them appears grouped by both merchants.

Expected Result:

Expenses with different merchants should be grouped separated on "Top Merchants"

Actual Result:

Expenses with different merchants are grouped together on "Top Merchants"

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7060713_1769642624469.Merchant.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022016661760883369633
  • Upwork Job ID: 2016661760883369633
  • Last Price Increase: 2026-02-18
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 28, 2026
  2. lanitochka17
    added this to #expensify-bugson Jan 28, 2026

  3. melvin-bot commented on Jan 28, 2026

    @melvin-bot
    melvin-botBot
    on Jan 28, 2026 – with Melvin Bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80672

  4. melvin-bot commented on Jan 28, 2026

    @melvin-bot
    melvin-botBot
    on Jan 28, 2026 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~022016661760883369633

  5. melvin-bot
    assigned
    lakchote
    on Jan 28, 2026
  6. melvin-bot
    changed the title [-]Reports - Expenses from different merchant grouped with same merchant on "Top Merchants"[/-] [+][$250] Reports - Expenses from different merchant grouped with same merchant on "Top Merchants"[/+] on Jan 28, 2026

  7. melvin-bot commented on Jan 28, 2026

    @melvin-bot
    melvin-botBot
    on Jan 28, 2026 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  8. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 28, 2026
  9. melvin-bot
    assigned
    heyjennahay
    on Jan 28, 2026

  10. melvin-bot commented on Jan 28, 2026

    @melvin-bot
    melvin-botBot
    on Jan 28, 2026 – with Melvin Bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  11. melvin-bot commented on Jan 28, 2026

    @melvin-bot
    melvin-botBot
    on Jan 28, 2026 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)

  12. melvin-bot
    assigned
    truph01
    on Jan 28, 2026

  13. 98 remaining items

  14. melvin-bot
    removed
    Overdue
    on Oct 20, 2026

  15. truph01 commented on Oct 20, 2026

    @truph01
    truph01
    on Oct 20, 2026
    Contributor

    Price increase request:

    Mandatory

    Proposed amount: 500$

    Why the work exceeded the issue: Originally, the issue was only intended to ensure that expenses from different merchants were grouped separately in Top Merchants. However, we later decided to expand the scope based on this discussion, which made the PR more complex.

    Regressions caused by this PR: #80823 (comment)

    Optional

    Scope expansion: #83733 (comment)

    Files touched: 48 files ~ +2,186 -715 line changes

    Additional fixes: #83733 (comment)

    Deploy blockers audited: #80823 (comment)

  16. truph01 commented on Oct 20, 2026

    @truph01
    truph01
    on Oct 20, 2026
    Contributor

    @neil-marcellini Could you check my price increase request?

  17. HiepPP commented on Oct 20, 2026

    @HiepPP
    HiepPP
    on Oct 20, 2026

    Hi @neil-marcellini @truph01, adding one more to the regression list above: #104299 also comes from #83733. I confirmed it here #104299 (comment) and I'll fix it in a follow-up PR. Thanks!

  18. truph01 commented on Oct 20, 2026

    @truph01
    truph01
    on Oct 20, 2026
    Contributor

    Hi @neil-marcellini @truph01, adding one more to the regression list above: #104299 also comes from #83733. I confirmed it here #104299 (comment) and I'll fix it in a follow-up PR. Thanks!

    @HiepPP I think #104299 is not a regression. It's how #83733 was designed:

    Keeping the user's : would be a nice-to-have improvement, not a regression fix.

  19. truph01 commented on Oct 21, 2026

    @truph01
    truph01
    on Oct 21, 2026
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    Match type on the advanced filters page

    1. Go to Reports > Expenses.
    2. Create expenses with merchants "I", "Ig", and "Igloo".
    3. Click Filters > Merchant.
    4. Verify the match type list shows Contains (selected by default) and Equal to.
    5. Enter Ig, keep Contains, and save. Then click View results.
    6. Verify the search query contains merchant*:Ig (or merchant:Ig), and "Ig" and "Igloo" are shown.
    7. Open Filters > Merchant again, select Equal to, and save. Then click View results.
    8. Verify the query contains merchant=Ig and only "Ig" is shown.

    Match type in the filter chip

    1. In the search filter bar, open the Merchant filter chip.
    2. Enter Ig, select Equal to, and apply.
    3. Verify the chip label shows Equal to "Ig" and only "Ig" is shown.
    4. Open the chip again, switch to Contains, and apply.
    5. Verify the chip label shows Contains "Ig", and "Ig" and "Igloo" are shown.

    Negated filter

    1. Open Filters > Merchant and switch the filter to "Is not".
    2. Verify the match type list is hidden.
    3. Enter Ig and apply. Verify the query contains -merchant:Ig and "Ig" is excluded.

    Merchant group drill-down

    1. Open a Top Merchants view (group by merchant).
    2. Click the "I" group.
    3. Verify only expenses with the merchant "I" are shown (not "Ig" or "Igloo"), and the query contains merchant="I".
    4. Go back, select the "I" group, and export it to CSV. Verify the file contains only "I" expenses.

    Small screen with the keyboard open

    1. On a small screen, open the Merchant filter chip and focus the input so the keyboard opens.
    2. Verify the match type list and the input stay visible and can scroll.
    3. Repeat on Filters > Merchant on the advanced filters page.

    Do we agree 👍 or 👎

  20. melvin-bot
    added
    WeeklyKSv2
    DailyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    DailyKSv2
    WeeklyKSv2
    on Oct 21, 2026
  21. melvin-bot
    assigned
    mallenexpensify
    on Oct 22, 2026

  22. melvin-bot commented on Oct 22, 2026

    @melvin-bot
    melvin-botBot
    on Oct 22, 2026 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  23. melvin-bot commented on Oct 22, 2026

    @melvin-bot
    melvin-botBot
    on Oct 22, 2026 – with Melvin Bot

    Payment Summary

    Resolving PRs:

    Upwork Job

    • Assignee: @HiepPP requires payment (Needs manual offer from BZ)
    • Reviewer: @truph01 owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon

  24. HiepPP commented on Oct 24, 2026

    @HiepPP
    HiepPP
    on Oct 24, 2026 – with Cursor

    Hi @mallenexpensify, the regression period ended on 2026-10-23, so this is ready for payment. Could you send me the manual Upwork offer when you get a chance? Thanks!

    @neil-marcellini, a friendly reminder about the price increase request above as well, so the offer can go out at the final amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNot a priority

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions