Repository navigation
Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in src/libs/ReportUtils.ts #66422
Description
This is part of deprecating Onyx.connect. Parent Issue
Details
- Module: src/libs/ReportUtils.ts
- Onyx Key:
ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS - Reference:
Line 1054: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS
Be sure to refactor methods using test driven development:
- Create a unit test for methods before refactoring
- Refactor the methods
- Ensure the unit test still runs after refactoring
- Reinforce the unit testing with a functional test and a QA test
- Once you are done, decrease the number of allowable ESLint warnings here to equal the number of
Onyx.connectreferences remaining in the code
Activity
tgolen commentedon Jul 16, 2025
Warning
DO NOT POST PROPOSALS ON THIS ISSUE!!
Bug-Zero Instructions
src/libs/ReportUtils.tsto removeOnyx.connect()references #66410melvin-bot commentedon Jul 16, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 30, 2025
@tgolen @NicMendonca this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
tgolen commentedon Aug 19, 2025
This is a long-running project, so this will be gotten to eventually.
122 remaining items
melvin-bot commentedon Oct 5, 2026
@DylanDylann
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.1-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 13, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
DylanDylann commentedon Oct 14, 2026
Not overdue. Waiting for the next PRs
melvin-bot commentedon Oct 14, 2026
@DylanDylann
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.8-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]