Repository navigation
Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION in src/libs/ReportUtils.ts #66418
Description
This is part of deprecating Onyx.connect. Parent Issue
Details
- Module: src/libs/ReportUtils.ts
- Onyx Key:
ONYXKEYS.COLLECTION.TRANSACTION - Reference:
Line 994: ONYXKEYS.COLLECTION.TRANSACTION
Be sure to refactor methods using test driven development:
- Create a unit test for methods before refactoring
- Refactor the methods
- Ensure the unit test still runs after refactoring
- Reinforce the unit testing with a functional test and a QA test
- Once you are done, decrease the number of allowable ESLint warnings here to equal the number of
Onyx.connectreferences remaining in the code
Activity
tgolen commentedon Jul 16, 2025
Warning
DO NOT POST PROPOSALS ON THIS ISSUE!!
Bug-Zero Instructions
src/libs/ReportUtils.tsto removeOnyx.connect()references #66410melvin-bot commentedon Jul 16, 2025
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 30, 2025
@tgolen @OfstadC this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
tgolen commentedon Aug 19, 2025
This is a long-running project, so this will be gotten to eventually.
266 remaining items
melvin-bot commentedon Oct 20, 2026
@linhvovan29546 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Julesssss commentedon Oct 20, 2026
Another PR merged today: #103683
melvin-bot commentedon Oct 23, 2026
@linhvovan29546 / @DylanDylann
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.18-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 26, 2026
@linhvovan29546 / @DylanDylann
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 26, 2026
@linhvovan29546 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Oct 28, 2026
@linhvovan29546 Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Oct 30, 2026
@linhvovan29546 Still overdue 6 days?! Let's take care of this!