Skip to content

[Due for payment 2026-11-02] Payment issue for E/App PR#104344 #105061

New issue
New issue
Open
Open
[Due for payment 2026-11-02] Payment issue for E/App PR#104344#105061
Assignees
mallenexpensifynkdengineer
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2OverdueTask

Description

@melvin-bot
melvin-bot
bot
opened on Oct 26, 2026

Issue created to compensate the Contributor+ member for their work on #104344
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/642622.
Contributor+ member who reviewed the PR - @nkdengineer.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot
    assigned
    nkdengineer
    on Oct 26, 2026

  2. melvin-bot commented on Oct 26, 2026

    @melvin-bot
    melvin-botBot
    on Oct 26, 2026 – with Melvin Bot
    Author

    @nkdengineer The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  3. melvin-bot
    added
    DailyKSv2
    Task
    on Oct 26, 2026

  4. melvin-bot commented on Oct 29, 2026

    @melvin-bot
    melvin-botBot
    on Oct 29, 2026 – with Melvin Bot
    Author

    @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot
    added
    Overdue
    on Oct 29, 2026

  6. nkdengineer commented on Oct 30, 2026

    @nkdengineer
    nkdengineer
    on Oct 30, 2026
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A (New feature)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    In an account with the commuterExclusionsArrangements on

    Test:

    1. Create (if needed) a WS with you and another 2-3 users
    2. Go to Workspace -> Overview and add a company address.
    3. Below, add an office. Keep the company address as default:
    4. Go to Workspace > Members and open member A.
    5. Verify there is an "Office location" row showing the default:
    6. Tap the row and select the other office. Confirm it swaps correctly:
    7. Confirm the update is posted to the admins chat:
    8. Go back to the members section and select members B and C, then open the "2 selected" dropdown. Verify "Change office location" is listed, and select it.
    9. Change their offices. Confirm it works and the messages are posted to the admins chat
    10. Go to Workspace > Distance rates > Settings > Exclude commutes, select "Exclude usual commute" and save. Choose Office-based.
    11. Back in Members, select B and C and open the dropdown. Verify "Change work arrangement" is listed, and select it.
    12. Select "Remote or mobile" and press "Confirm".
    13. Verify B's and C's member details show the new "Work arrangement", and #admins logs the change for each.
    14. In Workspace > Overview > Office locations, delete the new office
    15. Confirm the people in that office are now back to the primary

    Do we agree 👍 or 👎

  7. melvin-bot
    added
    WeeklyKSv2
    DailyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    Overdue
    DailyKSv2
    WeeklyKSv2
    on Oct 30, 2026
  8. melvin-bot
    assigned
    mallenexpensify
    on Nov 1, 2026

  9. melvin-bot commented on Nov 1, 2026

    @melvin-bot
    melvin-botBot
    on Nov 1, 2026 – with Melvin Bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. melvin-bot commented on Nov 1, 2026

    @melvin-bot
    melvin-botBot
    on Nov 1, 2026 – with Melvin Bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  11. melvin-bot
    added
    Overdue
    on Nov 4, 2026

  12. melvin-bot commented on Nov 5, 2026

    @melvin-bot
    melvin-botBot
    on Nov 5, 2026 – with Melvin Bot
    Author

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. melvin-bot commented on Nov 5, 2026

    @melvin-bot
    melvin-botBot
    on Nov 5, 2026 – with Melvin Bot
    Author

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. melvin-bot commented on Nov 5, 2026

    @melvin-bot
    melvin-botBot
    on Nov 5, 2026 – with Melvin Bot
    Author

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2OverdueTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions