Repository navigation
[Due for payment 2026-10-30] Two "marked as paid" messages are shown after switching to table view and paying invoice #104676
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.5.16-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103703
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
- User has received an invoice.
- Go to staging.new.expensify.com
- Open invoice report.
- Click More > Switch to table view.
- Bulk select the invoice.
- Click Pay > Pay as an individual > Mark as paid.
Expected Result:
Only one "marked as paid" message will be shown.
Actual Result:
Two "marked as paid" messages are shown after switching to table view and paying invoice via bulk select.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7292634_1792620389926.15.1.mp4
Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7292634
Issue Owner
Current Issue Owner: @daledahMetadata
Metadata
Assignees
Type
Projects
- Status
Activity
applause-bot commentedon Oct 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/845e92f5dea742bc354e61e4fe4185091708b726080a840976e262b786e4d00d
melvin-bot commentedon Oct 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #103703
melvin-bot commentedon Oct 22, 2026
@Beamanator @mountiny @lakchote @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #103703
github-actions commentedon Oct 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 22, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 22, 2026
Deploy Blocker Analysis
Causing PR: Reapply "Add a More menu option to switch single-expense reports between expense view and table view" — high confidence.
Root cause: In table view, one "Mark as paid" click on an invoice calls
payInvoicetwice. The invoice menu item pays through its ownonSelected, and the bulk action bar pays again throughonSubItemSelected. Each call adds its own optimistic "marked as paid" action and sends its ownPayInvoicerequest.Recommendation: Revert the PR. It is a new feature with several other open blockers on 9.5.16-0, and this bug sends duplicate payment requests.
Investigation details
Why this PR: It lets single-expense reports use table view and the selection toolbar (
MoneyRequestReportUtils.ts:172-177,ReportSecondaryActionUtils.ts:1235). Invoice reports have one expense, so you could not bulk-pay an invoice before this PR. The double-pay path already existed but was unreachable.Double call chain:
onSelected: () => onPress(...)(usePaymentOptions.ts:204-230). Non-invoice items have noonSelected, so only invoices are affected.PopoverMenucallsonItemSelected(item)and thenitem.onSelected()for the same click (PopoverMenu/index.tsx:536-551).onSelected→confirmPayment→payInvoice(call 1).onItemSelectedforwards toonSubItemSelected(BulkActionBarButton.tsx:105-106).ELSEWHEREcounts as a payment option, so it callsonSelectionModePaymentSelect(SelectionBulkActionBar.tsx:84-92) →selectPaymentType→confirmPayment→payInvoice(call 2).payInvoicedoes not check whether the invoice is already paid (PayMoneyRequest.ts:1132).MoneyReportHeaderKYCDropdown.tsx:99-111.The second call also drops
payAsBusiness. So "Pay as a business > Mark as paid" sends one business payment and one individual payment.Roll-forward fix (if you prefer not to revert):
SelectionBulkActionBar.tsxandMoneyReportHeaderKYCDropdown.tsx, return early when the item has its ownonSelected:useSelectionModePayment.ts, wrap the invoice leaf handlers withrunPaymentAction(...), asSettlementButtondoes, so delegate, locked-account, and validation checks still run.PAY_INVOICEexactly once, for both individual and business.I traced this by reading code at
beec381. I did not reproduce it in the app.Possible code review rule: A menu item with its own
onSelectedshould not also be handled by the parent'sonItemSelected/onSubItemSelected. One click should run the action once.view run
m-natarajan commentedon Oct 22, 2026
PR reverted and feature "Switch to table view." not available. iPhone 12/iOS 27.0.1, Samsung Galaxy A40/Android 11, Windows 10/Chrome/Build 9.5.16-1
MicrosoftTeams-video.43.mp4
MicrosoftTeams-video.42.mp4
2026-10-22.16-02-19.mp4
Beamanator commentedon Oct 22, 2026
thanks! closing!
[-]Two "marked as paid" messages are shown after switching to table view and paying invoice[/-][+][Due for payment 2026-10-30] Two "marked as paid" messages are shown after switching to table view and paying invoice[/+]melvin-bot commentedon Oct 23, 2026
@daledah
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.18-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-30. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]