Skip to content

Taxes - No action triggered while resizing "Tax Code" column to the left on "Taxes" table #104508

Closed
Closed
Taxes - No action triggered while resizing "Tax Code" column to the left on "Taxes" table#104508
Assignees
grgiaJS00001war-inKrishna2323
Labels
BugSomething is broken. Auto assigns a BugZero manager.Engineering

Description

@applause-bot
applause-bot
bot
opened on Oct 20, 2026

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.5.15-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103186
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Prerequisite: ResizableTableColumns beta enabled in troubleshoot.
Prerequisite 2: At least one workspace with "Taxes" enabled and "Tax Code" column visible.

  1. Open the staging.new.expensify.com website.
  2. Navigate to "Workspaces" > Workspace > "Taxes"
  3. Drag the right edge of "Tax Code" column to the left.
  4. Note that columns moves, but "Tax Code" and "Enabled" names remain in the same place.

Expected Result:

While dragging "Tax Code" right edge, columns should be narrowed or enlarged.

Actual Result:

No change can be seen in columns, while dragging "Tax Code" right edge.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7291371_1792527626260.Resize_2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7291371

Activity

  1. applause-bot
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 20, 2026

  2. applause-bot commented on Oct 20, 2026

    @applause-bot
    applause-botBot
    on Oct 20, 2026
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/c539812ce81402fee053448193430d5e8c986e9956d663d2bea14c073faa58b1

  3. gleitebr
    added this to #expensify-bugson Oct 20, 2026

  4. melvin-bot commented on Oct 20, 2026

    @melvin-bot
    melvin-botBot
    on Oct 20, 2026 – with Melvin Bot

    @JS00001 recently merged #103186, but they are OOO right now, so I'll auto-assign someone else.

  5. melvin-bot commented on Oct 20, 2026

    @melvin-bot
    melvin-botBot
    on Oct 20, 2026 – with Melvin Bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. melvin-bot
    assigned
    grgia
    on Oct 20, 2026
  7. github-actions
    added
    Engineering
    HourlyKSv2
    on Oct 20, 2026

  8. github-actions commented on Oct 20, 2026

    @github-actions
    github-actionsBot
    on Oct 20, 2026 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  9. melvin-bot
    assigned
    JS00001
    and
    Krishna2323
    on Oct 20, 2026

  10. melvin-bot commented on Oct 20, 2026

    @melvin-bot
    melvin-botBot
    on Oct 20, 2026 – with Melvin Bot

    @JS00001 @Krishna2323 you have been assigned to this deploy blocker because you reviewed the offending PR: #103186

  11. melvin-bot commented on Oct 20, 2026

    @melvin-bot
    melvin-botBot
    on Oct 20, 2026 – with Melvin Bot

    @war-in you have been assigned to this deploy blocker because you authored the offending PR: #103186

  12. melvin-bot
    assigned
    war-in
    on Oct 20, 2026

  13. melvin-bot commented on Oct 20, 2026

    @melvin-bot
    melvin-botBot
    on Oct 20, 2026 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  14. MelvinBot commented on Oct 20, 2026

    @MelvinBot
    MelvinBot
    on Oct 20, 2026
    Contributor

    Deploy Blocker Analysis

    Recommendation: demote. This isn't a regression from [Resizable columns] Absorb resize width in trailing columns, and reverting that PR won't fix it. The same behavior is already on production for anyone with the resizableTableColumns beta on. It is a cosmetic limitation of a beta-gated feature, so treat it as a normal follow-up.

    Root cause: The table picks the last column with a label to absorb leftover width (getResizableColumnLayout.ts#L72). In the Taxes table, that column is Enabled. Enabled has a fixed width (WorkspaceTaxesTable/index.tsx#L101), but its grid track is still 1fr.

    Here is what happens when you drag the Tax Code edge left:

    1. Tax Code narrows.
    2. The freed space goes into Enabled's 1fr track.
    3. The Tax Code label is left-aligned, so it stays put.
    4. The Enabled header and switch are right-aligned, so they stay put too (WorkspaceTaxesTableRow.tsx#L150-L163).

    The result is that only the resize line moves, which matches the video.

    Suggested fix: In getResizableColumnLayout, choose the last resizable labelled column as the one that absorbs leftover width, and fall back to the last labelled column. In Taxes, that is Tax Code, so dragging it would visibly resize the column while Enabled stays pinned right.

    Investigation details
    • Where it comes from: feat: let the user resize table columns by dragging their edges added resizing, including the Taxes table wiring. It was merged 2026-10-09, and its merge commit d1eff24 is already in production (cb936d5).
    • Production has the same setup: the Taxes table has columnResizingID={CONST.TABLES.COLUMN_RESIZING_IDS.WORKSPACE_TAXES} and a fixed-width enabled column (index.tsx#L101, L161). It uses the same "last labelled column absorbs leftover width" rule (getResizableColumnLayout.ts#L72).
    • Why the issue says it's not on production: the issue says "N/A - new feature, doesn't exist in prod". That is likely wrong. The bug should reproduce on production with the beta on.
    • Why [Resizable columns] Absorb resize width in trailing columns #103186 doesn't change this drag: it only lets resizable labelled columns to the right of the dragged column absorb the change (resolveDraggedColumnWidths.ts#L48-L50, L78). To the right of Tax Code there are only Enabled (fixed width) and the actions column (no label). So only Tax Code's width changes, the same as on production.
    • Why other tables look fine: Members works because its last labelled column (role) has no fixed width, so it can be resized and visibly absorbs the drag. Taxes is the one resizable table whose last labelled column has a fixed width.
    • Other PRs in the release: no other PR in Deploy Checklist: New Expensify 2026-10-20 touches the Taxes table or the column resize code.
    • Confidence: medium. This comes from tracing the code on staging (1b6bed5) and production (cb936d5). I didn't reproduce it in a browser.

    Next Steps: An engineer should decide whether to remove DeployBlockerCash. Reply with @MelvinBot <your feedback> to refine this analysis.

    view run

  15. war-in commented on Oct 21, 2026

    @war-in
    war-in
    on Oct 21, 2026
    Contributor

    I'd say this is expected. When dragging Tax code column the Enabled column is growing so it looks like nothing changed, but if the tax code is long enough, you'd see the column shrink

    cc @JS00001 for confirmation

  16. JS00001 commented on Oct 21, 2026

    @JS00001
    JS00001
    on Oct 21, 2026
    Contributor

    yep this looks expected

  17. JS00001
    closed this as completedon Oct 21, 2026
  18. github-project-automation
    moved this to Done in #expensify-bugson Oct 21, 2026
  19. JS00001
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions