Skip to content

[Due for payment 2026-10-26] Payment issue for E/App PR#102438 #104379

Open

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #102438
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/678389.
Contributor+ member who reviewed the PR - @daledah.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @daledah

Activity

  1. melvin-bot commented on Oct 19, 2026

    @melvin-bot
    Author

    @daledah The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. daledah commented on Oct 20, 2026

    @daledah
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. As a workspace admin, open a card expense on a draft report, tap Merge — verify cash expenses from other draft reports of the same submitter (same workspace) appear.
    2. As a workspace admin, select a card expense and a cash expense from different draft reports of the same submitter in Search, verify Merge is available.
    3. As a non-admin approver, open a card expense on a submitted (processing) report, tap Merge — verify only other expenses on that same report appear.
    4. As an admin who is also the submitter, tap Merge — verify all own eligible expenses appear (cross-report).
    5. As a workspace admin, merge a submitter's card expense on report A with a cash expense on report B, which also holds another expense — as the submitter, open report B and verify a system message from the admin reads "merged expenses and moved one to Deleted".
    6. Repeat with a cash expense that is the only expense on its report — verify that report is deleted and the system message appears on the report that holds the kept expense.
    7. Switch the language to Spanish — verify the system message is translated.

    Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions