Skip to content

Hybrid-Spend-Tap on Group in Top Merchant chart not only show expense in that group #104187

Closed
Closed
Hybrid-Spend-Tap on Group in Top Merchant chart not only show expense in that group#104187
Assignees
neil-marcellinitruph01
Labels
BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Description

@applause-bot
applause-bot
bot
opened on Oct 16, 2026

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.5.12-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83733
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: iPhone 11 iOS 26.7.1
App Component: Search

Action Performed:

Preconditions:

  • Create a new account
  • Create expenses with merchants "I", "Ig", and "Igloo".
  1. Open Hybrid app
  2. Go to Spend
  3. Tap on Top Merchants tab
  4. In the chart (pie is default), tap on any group (ex: "I)
  5. Change other View in display
  6. Tap on any group

Expected Result:

Verify only expenses with the merchant "I" are shown, and the query contains merchant="I"

Actual Result:

Chart only shows tooltips, nothing else happens

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7287829_1792125931628.Isue.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7287829

Activity

  1. applause-bot
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 16, 2026
  2. gleitebr
    added this to #expensify-bugson Oct 16, 2026

  3. applause-bot commented on Oct 16, 2026

    @applause-bot
    applause-botBot
    on Oct 16, 2026
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/45673d2bf7c00d2b402d24bf0e282dc748022d2e798b99c62ff3652b64545adc

  4. melvin-bot
    assigned
    neil-marcellini
    on Oct 16, 2026

  5. melvin-bot commented on Oct 16, 2026

    @melvin-bot
    melvin-botBot
    on Oct 16, 2026 – with Melvin Bot

    You have been assigned to this deploy blocker because you recently merged this PR: #83733

  6. melvin-bot
    assigned
    truph01
    on Oct 16, 2026

  7. melvin-bot commented on Oct 16, 2026

    @melvin-bot
    melvin-botBot
    on Oct 16, 2026 – with Melvin Bot

    @neil-marcellini @truph01 you have been assigned to this deploy blocker because you reviewed the offending PR: #83733

  8. melvin-bot commented on Oct 16, 2026

    @melvin-bot
    melvin-botBot
    on Oct 16, 2026 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  9. github-actions
    added
    Engineering
    HourlyKSv2
    on Oct 16, 2026

  10. github-actions commented on Oct 16, 2026

    @github-actions
    github-actionsBot
    on Oct 16, 2026 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  11. MelvinBot commented on Oct 16, 2026

    @MelvinBot
    MelvinBot
    on Oct 16, 2026
    Contributor

    Deploy Blocker Investigation

    Verdict: This is expected behavior. I recommend closing or demoting this issue, not reverting a PR.

    Causing PR: [Insights Polish] Introduce chart tooltips on mobile devices. It is in the current staging deploy and changes chart taps on purpose. Its description says: "On mobile, a tap on a chart now shows the tooltip of the tapped bar, period or slice and no longer opens the Spend page."

    Not the cause: [Payment due @truph01] fix: Add Contains / Equal to match type for the Merchant filter [80823]. It only changes which filter a tap adds. It was auto-assigned because QA ran its test plan, which was written before the tooltip change merged.

    Recommendation:

    1. Have OlGierd03 or an approver of the tooltip PR confirm the behavior, then remove DeployBlockerCash.
    2. Re-test the merchant filter on mobile through the Top Merchants table/list view by tapping the "I" row. You can also click a chart slice on web or desktop.
    3. Optional follow-up, not a blocker: add a "View expenses" link inside the pinned tooltip so phone users can still filter from a chart.
    Investigation details
    • Production: a touch tap on a pie slice opens the filtered list. The tap handler has no touch exception: PieChartContent.tsx#L140-L154.
    • Staging, pie chart: a touch tap shows the tooltip and returns before the code that opens the filtered list: PieChartContent.tsx#L167-L172.
    • Staging, bar and line charts: a shared setting, on by default, does the same: useChartInteractions.ts#L179 and #L433-L436. Only charts in chat messages opt out. This explains why step 5 (switching views) gives the same result.
    • Spend page: it still passes the tap handler to the chart (SearchChartView.tsx#L99-L113), but on touch the chart never calls it. Mouse clicks still filter.
    • Merchant filter PR: its only chart change is the filter syntax in chartGroupByConfig.ts#L71. It touches no tap-handling code. Reverting it would bring back the "I"/"Ig"/"Igloo" grouping bug.
    • Design intent: tracked in [Insights Polish] Showing tooltips on mobile devices. The tooltip PR's test steps cover Spend chart views, and design agreed in the PR thread.

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.

    view run

  12. OlGierd03 commented on Oct 16, 2026

    @OlGierd03
    OlGierd03
    on Oct 16, 2026
    Contributor

    This is expected. While polishing the new Insights page we decided to drop tap-to-drill-in on mobile and show the tooltip on tap instead and we did it for all the charts so they behave the same way. It comes from this part of the doc:

    On mobile, tap shows the tooltip, and there is no tap-to-drill-in. Drilling into Spend on mobile happens from each card's ⋮ menu, using the existing View on Spend action.

    @JmillsExpensify can you confirm?

  13. JmillsExpensify commented on Oct 16, 2026

    @JmillsExpensify
    JmillsExpensify
    on Oct 16, 2026 – with Linear Code
    Contributor

    Commented elsewhere, though I agree. I don't understand why this is logged as a blocker.

  14. OlGierd03 commented on Oct 16, 2026

    @OlGierd03
    OlGierd03
    on Oct 16, 2026
    Contributor

    @neil-marcellini Could you close this one out when you get a chance? Thanks!

  15. cristipaval
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 16, 2026
  16. cristipaval
    closed this as completedon Oct 16, 2026
  17. github-project-automation
    moved this to Done in #expensify-bugson Oct 16, 2026

  18. trjExpensify commented on Oct 16, 2026

    @trjExpensify
    trjExpensify
    on Oct 16, 2026
    Contributor

    Reopening this. I don't think it has anything to do with the issue commented on earlier.

  19. trjExpensify
    reopened this on Oct 16, 2026

  20. trjExpensify commented on Oct 16, 2026

    @trjExpensify
    trjExpensify
    on Oct 16, 2026
    Contributor

    I agree about the tap to be clear, but let's confirm these steps (particularly step 5) and what the merchant results return when you get to the table.

    1. Open Hybrid app
    2. Go to Spend
    3. Tap on Top Merchants tab
    4. In the chart (pie is default), tap on any group (ex: "I)
    5. Change other View in display
    6. Tap on any group

    Expected results:
    Verify only expenses with the merchant "I" are shown, and the query contains merchant="I"

  21. neil-marcellini commented on Oct 16, 2026

    @neil-marcellini
    neil-marcellini
    on Oct 16, 2026
    Contributor

    Looks like the table still works fine.

    v9.5.12-1

    ScreenRecording_10-16-2026.07-01-45_1.MP4
  22. neil-marcellini
    closed this as completedon Oct 16, 2026

  23. trjExpensify commented on Oct 16, 2026

    @trjExpensify
    trjExpensify
    on Oct 16, 2026
    Contributor

    Cool, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions