[Payment due @situchan] Add Held search filter for expenses by c3024 · Pull Request #104076 · Expensify/App

c3024 · 2026-10-15T11:08:15Z

Explanation of Change

Adds a "Held" Yes/No filter for expenses. The query key is held:yes / held:no, and it matches expenses that are currently on hold. It works like Billable: filter list page, filter bar chip, typed query with autocomplete and negation. Hold only exists on expenses, so the filter is only offered for the Expense type.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/691882
PROPOSAL:

Tests

As a member of a workspace, create three expenses on a report.
Hold the first expense.
Hold the second expense, then remove the hold.
Go to Spend > Expenses and click Filters.
Verify Held appears below Rejected.
Select Held > Yes.
Verify a "Held: Yes" chip appears and only the first expense is listed.
Change the chip to No.
Verify the second and third expenses are listed and the first is not.
Go to Spend > Reports and click Filters.
Verify Held is not offered.
Click the search icon and type held:.
Verify the suggestions are held:no and held:yes.
Search for type:expense -held:yes after clicking on the Search magnifying glass icon.
Verify the first expense is not listed.

Verify that no errors appear in the JS console

Offline tests

Go offline.
Click Filters on Spend > Expenses and select Held > Yes.
Verify the "Held: Yes" chip appears.
Go online.
Verify the results load and show only held expenses.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-10-15T11:08:41Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-10-15T11:12:46Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
...ents/Search/FilterComponents/ListFilterContent.tsx	`10.52% <ø> (ø)`
src/components/Search/SearchTableHeader.tsx	`48.91% <ø> (ø)`
...ents/TransactionItemRow/TransactionItemRowWide.tsx	`98.48% <100.00%> (+0.02%)`	⬆️
src/hooks/useAdvancedSearchFilters.ts	`97.29% <ø> (ø)`
src/hooks/useAutocompleteSuggestions.ts	`73.07% <ø> (ø)`
src/libs/ReportUtils.ts	`88.71% <100.00%> (+0.08%)`	⬆️
src/libs/SearchParser/autocompleteParser.js	`61.83% <ø> (+0.09%)`	⬆️
src/libs/SearchParser/searchParser.js	`85.71% <ø> (+0.06%)`	⬆️
src/libs/SearchQueryUtils.ts	`91.04% <100.00%> (+0.02%)`	⬆️
... and 5 more
... and 281 files with indirect coverage changes

…-search-filter # Conflicts: # src/CONST/index.ts # src/components/Search/FilterComponents/ListFilterContent.tsx # src/hooks/useAdvancedSearchFilters.ts # src/hooks/useAutocompleteSuggestions.ts # src/languages/de.ts # src/languages/el.ts # src/languages/en.ts # src/languages/es.ts # src/languages/fr.ts # src/languages/it.ts # src/languages/ja.ts # src/languages/nl.ts # src/languages/pl.ts # src/languages/pt-BR.ts # src/languages/zh-hans.ts # src/libs/SearchAutocompleteUtils.ts # src/libs/SearchParser/autocompleteParser.js # src/libs/SearchParser/autocompleteParser.peggy # src/libs/SearchParser/baseRules.peggy # src/libs/SearchParser/searchParser.js # src/libs/SearchParser/searchParser.peggy # src/libs/SearchQueryUtils.ts # src/libs/SearchUIUtils.ts # src/types/form/SearchAdvancedFiltersForm.ts # tests/unit/Search/SearchQueryUtilsTest.ts # tests/unit/SearchParserTest.ts # tests/unit/hooks/useAutocompleteSuggestions.test.ts

chatgpt-codex-connector · 2026-10-20T05:33:35Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-21T10:59:05.549690Z	`926d26d`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

melvin-bot · 2026-10-20T05:33:56Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-10-20T06:38:05Z

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

JmillsExpensify

This looks great. Excited to see this going through.

c3024 · 2026-10-21T01:53:11Z

@parasharrajat could you review this PR?

JmillsExpensify · 2026-10-21T09:37:53Z

I'm pretty sure he's out and we need to keep this moving, so I'll find an alt.

situchan · 2026-10-21T09:43:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

situchan

Code looks good. Some minor nits:

JmillsExpensify · 2026-10-21T10:26:35Z

@c3024 back to you

melvin-bot · 2026-10-21T10:39:31Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/691882.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

MelvinBot · 2026-10-21T10:43:21Z

Code review

I found no blocking bugs. Held is wired into every place Billable and Declined use, and the new tests cover parsing, negation, form round-trips, autocomplete, and sorting.

Two things to address before merge:

Update the PR description. The second commit adds a sortable Held column (column picker, table header, cell, local sort), but the Explanation and Tests only describe the filter. Please mention the column and add test steps for it. For example: enable Held in Columns, verify Yes/No cells, and sort by Held in both directions.
Confirm backend support for the column. The filter is clearly supported (your screenshots show results). Please confirm the backend also accepts columns:held and sortBy:held, so paginated server-side sorting matches the local sort.

Minor, optional

Held is the first column mapped to null that still sorts, so it needs a special case in SearchUIUtils.ts:4153 and SearchUIUtils.ts:3968. It works and is commented. If another derived column appears, a small "computed sort value" map would be cleaner than more sortBy === X checks.
The shared boolean-filter-keys set that situchan suggested is tracked as a follow-up, which is fine.

What I checked

isOnHold returns !!comment.hold, so an unheld expense (hold: '') counts as not held. Search rows carry comment.hold, so the cell, filter chip, and both sort paths agree.
The Held filter is limited to the Expense type (ALLOWED_TYPE_FILTERS, typeFiltersKeys), and a test confirms it is dropped for expense reports.
The Stopwatch chip icon matches the existing Hold/Unhold actions.
CI: every check passes except Check independent approval (expected) and one test shard that was still running.

view run

MelvinBot · 2026-10-21T11:05:01Z

🤖 Web test steps verification results: ⚠️ partial

The Held filter, chip, negation, and autocomplete all work on Spend > Expenses, and Held is correctly absent from Spend > Reports filters. The Columns picker showed Held, Billable, and Reimbursable as disabled in the test browser, so the column and sort steps could not be checked.

Step	Status
Filters lists Held below Rejected; Held > Yes shows a "Held: Yes" chip and only the held expense Held sits below Rejected. Held: Yes showed only "Merchant Held" ($10.00).	✅
Held: No lists the two unheld expenses and not the held one Showed "Merchant Plain" ($15.00) and "Merchant Billable" ($20.00) and excluded "Merchant Held".	✅
Columns picker: enable Held, Billable, Reimbursable and check Yes/No cells The test browser reported all three as disabled, including with only two other columns selected and at 1920x1080. Billable and Reimbursable existed before this PR and were also blocked, and the code disables only required columns, so this looks like a test-harness problem, not a regression.	❌
Held column header sorts both directions without error Blocked: the Held column could not be added, so its header never appeared.	❌
Billable and Reimbursable headers still sort correctly Blocked by the same Columns picker problem.	❌
Report view: enable Held in Columns and sort by it Blocked: the report's Columns picker showed the same disabled state.	❌
Spend > Reports > Filters does not offer Held The Reports filter list has no Held entry.	✅
Typing held: suggests held:no and held:yes; type:expense -held:yes excludes the held expense Both suggestions appeared. The negated query showed a "-Held: Yes" chip and excluded "Merchant Held".	✅
No error screens during any step No crash screens, error banners, or console errors.	✅

Code check: no regressions found

Parity: Every file that handles the Billable and Declined keys now handles Held. The only other place Declined appears is the expense-report filter list, which leaves Held out on purpose.
Search syntax: held was not an existing key or value anywhere in search. It does not prefix-match another key in the parser, so existing queries parse the same way.
Shared Yes/No cell refactor: Reimbursable and Billable keep the same value, style, and key, so those cells render the same as before.
Sorting: The new sortKey branch only applies when sortBy is Held. Every other column sorts the same as before.
Columns picker failure: ColumnsSettingsList.tsx:141 disables only required columns. Held is not required in SearchColumnsPage.tsx:47-61. Your own screenshots also show the Held column sorted. Please run a quick manual check of steps 3–6 to confirm.
Not verified: I could not check whether the backend handles columns:held and sortBy:held across pages. The live filter results show the backend handles the held filter.

view run · view recording

github-actions · 2026-10-21T12:51:29Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-21T12:55:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-21T12:55:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104076.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bc95a71-f8df561-de17bf6924b74456e167ceb69e25eb20c876d5e4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bc95a71-f8df561-951a79479c5d0b54cfcb1e4079f7ecaac8b94b42/index.html

Web 🕸️
https://104076.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-21T20:08:24Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-21T20:24:11Z

A help site update is needed. This PR adds a new user-facing feature that isn't behind a beta: the Held filter and the held: search operator.

I created a draft docs PR: Docs updates for E/A#104076 Add held: search operator to search operators article

It adds one held: row to the expense operators table in Use-Search-Operators-to-Filter-and-Analyze.md:82, beside billable: and reimbursable:. It also adds two keywords to the article.

Verification

I checked these labels in the web app:

Held appears after Rejected in Spend > Expenses > Filters.
The Held options are Yes and No.
Typing held: in the search field suggests held:no and held:yes.

@c3024, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run · view recording

OSBotify · 2026-10-22T19:22:32Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-10-22T19:33:23Z

A help site update is needed, and it's already open: [No QA] Docs updates for E/A#104076 Add held: search operator to search operators article. I didn't create a second PR.

This PR adds a new, non-beta feature: the Held expense filter and the held: search operator. The existing PR adds one held: row to the expense operators table in Use Search Operators to Filter and Analyze. It also adds two keywords. That PR is already labeled HelpDot, assigned to you, and marked ready for review.

UI check (dev web)

Held appears directly below Rejected in Spend > Expenses > Filters.
Its options are Yes and No.
Typing held: in the search field suggests held:no and held:yes.

@c3024, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run · view recording

Add Held search filter for expenses

b1c8cb3

melvin-bot Bot assigned c3024 Oct 15, 2026

c3024 added 2 commits October 16, 2026 13:33

Add sortable Held column for expenses

1e9cb0b

c3024 changed the title ~~[HOLD Auth#25515] Add Held search filter for expenses~~ Add Held search filter for expenses Oct 20, 2026

This was referenced Oct 20, 2026

[$175] Add a "Rejected" and a "Held" suggested search that appears once a user has rejected/held expenses #103339

Open

Add a Rejected suggested search that appears once the user has a rejected expense #104438

Draft

c3024 marked this pull request as ready for review October 20, 2026 05:33

c3024 requested review from a team as code owners October 20, 2026 05:33

melvin-bot Bot requested review from JmillsExpensify and parasharrajat and removed request for a team October 20, 2026 05:33

melvin-bot Bot removed the request for review from a team October 20, 2026 05:33

This comment has been minimized.

Sign in to view

JmillsExpensify previously approved these changes Oct 20, 2026

View reviewed changes

JmillsExpensify requested review from situchan and removed request for parasharrajat October 21, 2026 09:39

situchan reviewed Oct 21, 2026

View reviewed changes

Comment thread src/components/TransactionItemRow/TransactionItemRowWide.tsx Outdated

Comment thread src/libs/SearchQueryUtils.ts

Comment thread tests/unit/ReportUtilsTest.ts Outdated

Share the Yes/No search cell and split the held sort test steps

926d26d

c3024 dismissed JmillsExpensify’s stale review via 926d26d October 21, 2026 10:38

situchan approved these changes Oct 21, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 October 21, 2026 10:39

melvin-bot Bot changed the title ~~Add Held search filter for expenses~~ [Payment due @situchan] Add Held search filter for expenses Oct 21, 2026

JS00001 approved these changes Oct 21, 2026

View reviewed changes

JS00001 merged commit bc95a71 into Expensify:main Oct 21, 2026
39 of 43 checks passed

OSBotify mentioned this pull request Oct 21, 2026

Deploy Checklist: New Expensify 2026-10-21 #104620

Open

70 of 83 tasks

MelvinBot mentioned this pull request Oct 21, 2026

[No QA] Docs updates for E/A#104076 Add held: search operator to search operators article #104641

Open

38 tasks

Conversation

c3024 commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 15, 2026

Uh oh!

codecov Bot commented Oct 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

melvin-bot Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

This comment has been minimized.

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 commented Oct 21, 2026

Uh oh!

JmillsExpensify commented Oct 21, 2026

Uh oh!

situchan commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JmillsExpensify commented Oct 21, 2026

Uh oh!

melvin-bot Bot commented Oct 21, 2026

Uh oh!

MelvinBot commented Oct 21, 2026

Code review

Uh oh!

MelvinBot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

MelvinBot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Oct 22, 2026

Uh oh!

MelvinBot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

c3024 commented Oct 15, 2026 •

edited

Loading

codecov Bot commented Oct 15, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 20, 2026 •

edited

Loading

situchan commented Oct 21, 2026 •

edited

Loading

MelvinBot commented Oct 21, 2026 •

edited

Loading

MelvinBot commented Oct 21, 2026 •

edited

Loading

MelvinBot commented Oct 22, 2026 •

edited

Loading