You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-03] Connections - URL ends with /accounting after navigating from More features #104013
Version Number: 9.5.9-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#102265 Email or phone of affected tester (no customers):[email protected] Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable unifiedConnections beta.
Workspace is connected to Sage Intacct.
Go to staging.new.expensify.com
Go to workspace settings > More features.
Click Categories toggle.
Click Manage settings.
→ URL ends with /accounting.
Click Connections tab again.
→ URL ends with /connections
Expected Result:
In Step 4, after navigating to Connections from Manage settings button on More features, URL should end with /connections.
Actual Result:
In Step 4, after navigating to Connections from Manage settings button on More features, URL should end with /accounting.
In Step 5, after clicking Connections tab again, URL ends with /connections.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause: On More features, a disabled Categories, Tags, or Taxes toggle opens a modal. Its "Manage settings" button always navigates to the old route, even when the unifiedConnections beta is on: WorkspaceMoreFeaturesPage/index.tsx:219. A beta HOC on PolicyAccountingPage still renders the Connections screen, so only the URL is wrong (/accounting instead of /connections).
Recommended fix (roll forward): Change line 219 to use the beta flag already defined at line 107:
A revert isn't worth it: it would pull out the whole Connections consolidation to fix a URL. I agree with the demotion, since the flow is behind a beta.
The PR added WORKSPACE_CONNECTIONS at ROUTES.ts:3593-3594 and wrapped the old page with withUnifiedConnectionsBeta at PolicyAccountingPage.tsx:432. That is why step 4 shows the right screen with the old URL.
The PR edited this file (it hides the Integrate section under the beta at L375) but missed the modal navigation.
The other POLICY_ACCOUNTING calls on this page (L244, L405) are in the Integrate section, which is hidden under the beta.
About 19 other src/ files still call ROUTES.POLICY_ACCOUNTING.getRoute. They render the right screen through the HOC but may show /accounting. Consider sweeping them in the follow-up.
Next Steps:Krishna2323, reply with @MelvinBot implement this to have me open a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Connections - URL ends with /accounting after navigating from More features[/-][+][Due for payment 2026-11-03] Connections - URL ends with /accounting after navigating from More features[/+]on Oct 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-03. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Oct 14, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/2fa9f30a5eeb3ba391aa93cd38251ea14186284ec6b32d7a06e3846feaeb48e4
melvin-bot commentedon Oct 14, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #102265
github-actions commentedon Oct 14, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 14, 2026
@lakchote @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #102265
melvin-bot commentedon Oct 14, 2026
@Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #102265
melvin-bot commentedon Oct 14, 2026
💬 A slack conversation has been started in #expensify-open-source
2 remaining items
lakchote commentedon Oct 14, 2026
Behind beta, demoting.
MelvinBot commentedon Oct 14, 2026
Deploy Blocker Investigation
Causing PR: Consolidate integration to one Connection screen (high confidence). No other PR in the staging checklist touches this flow.
Root cause: On More features, a disabled Categories, Tags, or Taxes toggle opens a modal. Its "Manage settings" button always navigates to the old route, even when the
unifiedConnectionsbeta is on: WorkspaceMoreFeaturesPage/index.tsx:219. A beta HOC onPolicyAccountingPagestill renders the Connections screen, so only the URL is wrong (/accountinginstead of/connections).Recommended fix (roll forward): Change line 219 to use the beta flag already defined at line 107:
A revert isn't worth it: it would pull out the whole Connections consolidation to fix a URL. I agree with the demotion, since the flow is behind a beta.
Investigation details
WORKSPACE_CONNECTIONSat ROUTES.ts:3593-3594 and wrapped the old page withwithUnifiedConnectionsBetaat PolicyAccountingPage.tsx:432. That is why step 4 shows the right screen with the old URL.POLICY_ACCOUNTINGcalls on this page (L244, L405) are in the Integrate section, which is hidden under the beta.src/files still callROUTES.POLICY_ACCOUNTING.getRoute. They render the right screen through the HOC but may show/accounting. Consider sweeping them in the follow-up.Next Steps:
Krishna2323, reply with@MelvinBot implement thisto have me open a draft PR, or@MelvinBot <your feedback>to refine this analysis.lakchote commentedon Oct 19, 2026
@Krishna2323 are you picking this up as a follow-up to #102265?
Krishna2323 commentedon Oct 20, 2026
PR is ready for review: #104402
cc: @situchan @lakchote
[-]Connections - URL ends with /accounting after navigating from More features[/-][+][Due for payment 2026-11-03] Connections - URL ends with /accounting after navigating from More features[/+]melvin-bot commentedon Oct 27, 2026
@Krishna2323 / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-03. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]