Skip to content

[Due for payment 2026-11-03] Connections - URL ends with /accounting after navigating from More features #104013

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.9-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #102265
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable unifiedConnections beta.
  • Workspace is connected to Sage Intacct.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > More features.
  3. Click Categories toggle.
  4. Click Manage settings.
    → URL ends with /accounting.
  5. Click Connections tab again.
    → URL ends with /connections

Expected Result:

In Step 4, after navigating to Connections from Manage settings button on More features, URL should end with /connections.

Actual Result:

In Step 4, after navigating to Connections from Manage settings button on More features, URL should end with /accounting.
In Step 5, after clicking Connections tab again, URL ends with /connections.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7286388_1791991775691.6.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7286388

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 14, 2026
  2. applause-bot commented on Oct 14, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/2fa9f30a5eeb3ba391aa93cd38251ea14186284ec6b32d7a06e3846feaeb48e4

  3. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #102265

  4. github-actions commented on Oct 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    @lakchote @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #102265

  6. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    @Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #102265

  7. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. 2 remaining items

  9. lakchote commented on Oct 14, 2026

    @lakchote
    Contributor

    Behind beta, demoting.

  10. MelvinBot commented on Oct 14, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Investigation

    Causing PR: Consolidate integration to one Connection screen (high confidence). No other PR in the staging checklist touches this flow.

    Root cause: On More features, a disabled Categories, Tags, or Taxes toggle opens a modal. Its "Manage settings" button always navigates to the old route, even when the unifiedConnections beta is on: WorkspaceMoreFeaturesPage/index.tsx:219. A beta HOC on PolicyAccountingPage still renders the Connections screen, so only the URL is wrong (/accounting instead of /connections).

    Recommended fix (roll forward): Change line 219 to use the beta flag already defined at line 107:

    Navigation.navigate(isUnifiedConnectionsBetaEnabled ? ROUTES.WORKSPACE_CONNECTIONS.getRoute(policyID) : ROUTES.POLICY_ACCOUNTING.getRoute(policyID));

    A revert isn't worth it: it would pull out the whole Connections consolidation to fix a URL. I agree with the demotion, since the flow is behind a beta.

    Investigation details
    • The modal is wired to Categories (L533), Tags (L554), and Taxes (L572), so all three have the bug.
    • The PR added WORKSPACE_CONNECTIONS at ROUTES.ts:3593-3594 and wrapped the old page with withUnifiedConnectionsBeta at PolicyAccountingPage.tsx:432. That is why step 4 shows the right screen with the old URL.
    • The PR edited this file (it hides the Integrate section under the beta at L375) but missed the modal navigation.
    • The same PR already uses the correct pattern in AccountingContext/index.tsx:130.
    • The other POLICY_ACCOUNTING calls on this page (L244, L405) are in the Integrate section, which is hidden under the beta.
    • About 19 other src/ files still call ROUTES.POLICY_ACCOUNTING.getRoute. They render the right screen through the HOC but may show /accounting. Consider sweeping them in the follow-up.

    Next Steps: Krishna2323, reply with @MelvinBot implement this to have me open a draft PR, or @MelvinBot <your feedback> to refine this analysis.

  11. lakchote commented on Oct 19, 2026

    @lakchote
    Contributor

    @Krishna2323 are you picking this up as a follow-up to #102265?

  12. Krishna2323 commented on Oct 20, 2026

    @Krishna2323
    Contributor

    PR is ready for review: #104402

    cc: @situchan @lakchote

  13. changed the title [-]Connections - URL ends with /accounting after navigating from More features[/-] [+][Due for payment 2026-11-03] Connections - URL ends with /accounting after navigating from More features[/+] on Oct 27, 2026
  14. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    @Krishna2323 / @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-03. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringOverdue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions