You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-28] [Insights][R2][App] Draw Previous period for Spend over time #103768
changed the title [-][Insights][R2][App] Draw Previous period for Spend over time[/-][+][Due for payment 2026-10-28] [Insights][R2][App] Draw Previous period for Spend over time[/+]on Oct 21, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.15-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-28. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Enable the insightsPage and insightsCompare betas. Go to Insights and set Date to Year to date, Group by to Month and Compare to Previous period. Verify that Spend over time shows two lines: the current year, and last year in a lighter shade of the same color, with the current line drawn on top.
Hover over a point on desktop web, or tap it on other platforms. Verify that the tooltip is titled with the month, like "April", and has one row per period, like "2026: [amount] ([share]%)" and "2025: [amount] ([share]%)", followed by the change with an arrow and percentage.
Verify that only the current line's last segment is dashed while the current month is still in progress, and that the previous year's line is solid all the way.
Set Group by to Week. Verify that the tooltip titles the points by position, like "Week 2", since the weeks of the two years share no calendar name.
Set Date to This month and Group by to Day. Verify that the line for the previous month stops where that month has no matching day, like October 31 against September, instead of dropping to $0.
Set Date to Last month and Group by to Day. Add an expense dated August 31st. Verify that the previous period's line ends with a point for the 31st after September 30, where the current line has no point. Hover or tap it (on mobile) and verify that the tooltip is titled "31st" and shows only "August 2026: [amount]", with no change line.
Find a point where the previous period had no expenses. Verify that the tooltip shows the change percentage as —.
On desktop web, click a point. Verify that Spend opens filtered to that point's dates in the current period.
Set a custom Date range of October 1 to October 31, 2026 and Group by to Day. Hover or tap the first point. Verify that the tooltip rows are named "Oct 1, 2026" and "Aug 31, 2026", since a custom range compares against the same number of days just before it.
Set Date to This month and add an expense dated the last day of the month before last. Verify that it isn't counted in the previous period.
Set Compare to Average. Verify that Spend over time shows the Average line, as before this change.
Switch to dark mode and verify that the previous period's line and tooltip dot use the darker shade.
Set Compare to None and verify that all charts look as they did before this change.
Activity
melvin-bot commentedon Oct 16, 2026
@mhawryluk Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-][Insights][R2][App] Draw Previous period for Spend over time[/-][+][Due for payment 2026-10-28] [Insights][R2][App] Draw Previous period for Spend over time[/+]melvin-bot commentedon Oct 21, 2026
@truph01
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.15-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-28. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
truph01 commentedon Oct 23, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
insightsPageandinsightsComparebetas. Go to Insights and set Date to Year to date, Group by to Month and Compare to Previous period. Verify that Spend over time shows two lines: the current year, and last year in a lighter shade of the same color, with the current line drawn on top.—.Do we agree 👍 or 👎
truph01 commentedon Oct 23, 2026
This is part of https://github.com/orgs/Expensify/projects/317. As we can see, a few completed issues were paid at the old rate of $250.
melvin-bot commentedon Oct 27, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 27, 2026
Payment Summary
Resolving PRs:
[NoQA] [Insights] Draw Previous period for Spend over time #103786
Contributor: @mhawryluk does not require payment (Contractor)
Reviewer: @truph01 owed $175 via NewDot
BugZero Checklist (@mallenexpensify)