Remove getReportTransactions default in getPayMoneyRequestParams (Part 8) by linhvovan29546 · Pull Request #103682 · Expensify/App

linhvovan29546 · 2026-10-11T09:34:32Z

Explanation of Change

Part 8 of the getReportTransactions removal (#66418). getPayMoneyRequestParams no longer falls back to the deprecated, Onyx.connect-backed getReportTransactions(iouReport?.reportID). It now receives the report's transactions as an explicit param, used to decide the amount to pay (held expenses), whether to move scan-failed transactions, and which expenses to optimistically unhold on a full pay.

PayMoneyRequest.ts: added required iouReportTransactions (payMoneyRequest, getPayMoneyRequestParams) and invoiceReportTransactions (payInvoice); removed the getReportTransactions import and its seatbelt entry.
Components/hooks (PayPrimaryAction, MoneyReportHeaderSecondaryActions, PayActionButton, PayActionCell, useSelectionModePayment) pass the transactions they already have.
useHoldMenuSubmit adds useReportTransactions(moneyRequestReport?.reportID).
useSearchBulkActions groups allTransactions by report once before the bulk-pay loop.
Search.ts getPayActionCallback takes iouReportTransactions and forwards it from handleActionButtonPress.
PayMoneyRequestTest.ts passes the transactions explicitly.

Fixed Issues

$ #66418
PROPOSAL: N/A

Tests

As user A, request two expenses from user B in a DM, so there is one IOU report.
As user B (the payer), open the report and hold one expense (More > Hold).
Verify the report header shows Pay with only the unheld amount.
Click Pay > Mark as paid. In "Confirm payment amount" choose Pay only xxX. Verify the unheld expense is paid and the held expense moves to a new outstanding report.
Repeat steps 1-3 with a new IOU report and choose the full amount (Pay xxY) instead. Verify the whole report is paid and the held expense is unheld.
Open an unpaid invoice and pay it. Verify it is marked paid.
Go to Spend > Reports, find a payable report and click Pay on the row. Verify it is paid.

Offline tests

Go offline.
Pay an expense report (full, and partial with a held expense).
Verify the report is optimistically shown as paid, held expenses are unheld on full pay, and no errors appear.
Go back online and verify the payment syncs without errors.

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-10-14.at.14.37.07.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-14.at.14.05.05.mov

Screen.Recording.2026-10-14.at.14.05.44.mov

Screen.Recording.2026-10-14.at.14.06.49.mov

Screen.Recording.2026-10-14.at.14.08.45.mov

…ult in getPayMoneyRequestParams (Part 8) getPayMoneyRequestParams now takes the report's transactions as an explicit param instead of falling back to the deprecated Onyx.connect-backed global. payMoneyRequest and payInvoice forward it; components and hooks pass the transactions they already have, useHoldMenuSubmit adds useReportTransactions, and bulk pay groups allTransactions by report once before its loop.

codecov · 2026-10-11T09:37:28Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...oneyReportHeaderPrimaryAction/PayPrimaryAction.tsx	`0.00% <ø> (ø)`
...Item/MoneyRequestReportPreview/PayActionButton.tsx	`96.36% <ø> (ø)`
...h/SearchList/ListItem/ActionCell/PayActionCell.tsx	`94.64% <ø> (ø)`
src/hooks/useSearchBulkActions.ts	`80.71% <100.00%> (+0.49%)`	⬆️
src/hooks/useSelectionModePayment.ts	`63.30% <ø> (ø)`
src/libs/actions/IOU/PayMoneyRequest.ts	`81.18% <100.00%> (-0.68%)`	⬇️
src/libs/actions/Search.ts	`67.27% <ø> (-0.33%)`	⬇️
src/hooks/useHoldMenuSubmit.ts	`0.00% <0.00%> (ø)`
...eaderActions/MoneyReportHeaderSecondaryActions.tsx	`0.64% <0.00%> (ø)`
... and 348 files with indirect coverage changes

…g allTransactions

melvin-bot · 2026-10-14T07:39:23Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-14T07:39:27Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-14T07:58:27.293175Z	`dadde01`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

DylanDylann · 2026-10-15T04:34:50Z

                paymentMethodType: type,
                chatReport,
                invoiceReport: moneyRequestReport,
+                invoiceReportTransactions: allTransactions,


I suggest renaming this to moneyReportTransaction to avoid confusion

Updated f95a962

DylanDylann · 2026-10-15T04:40:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-10-15.at.11.38.07.mov

github-actions · 2026-10-15T16:53:35Z

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-15T16:57:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-15T16:59:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103682.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-37ea23d-0c4b36f-ff15c4ce9da552d77eb1ad1c3f31767a34c5d2ba/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-37ea23d-0c4b36f-26c59b5745f8852307e6e0afd97086a2f507cb23/index.html

Web 🕸️
https://103682.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-16T12:13:26Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.13-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-16T12:17:59Z

No help site update needed. This PR is an internal refactor: it passes report transactions into the pay functions explicitly instead of reading them through the deprecated getReportTransactions, so paying, partial pay with held expenses, and invoice payment work the same way for users.

view run

jponikarchuk · 2026-10-16T13:29:54Z

The Deploy Blocker issue #104227 is repro on all PRs. Could you please double check if it's not introduced by #103682

jponikarchuk · 2026-10-16T13:42:39Z

The Deploy Blocker issue #104229 is repro on all PRs. Could you please double check if it's not introduced by #103682

jponikarchuk · 2026-10-18T16:46:35Z

The Deploy Blocker issue #104319 is repro on all PRs. Could you please double check if it's not introduced by #102265

jponikarchuk · 2026-10-18T17:11:16Z

The Deploy Blocker issue #104320 is repro on all PRs. Could you please double check if it's not introduced by #102265

jponikarchuk · 2026-10-18T17:26:10Z

The Deploy Blocker issue #102265 is repro on all PRs. Could you please double check if it's not introduced by #102265

melvin-bot Bot assigned linhvovan29546 Oct 11, 2026

linhvovan29546 changed the title ~~Remove getReportTransactions callers' reliance on the deprecated defa…~~ Remove getReportTransactions default in getPayMoneyRequestParams (Part 8) Oct 11, 2026

linhvovan29546 added 3 commits October 11, 2026 17:10

chore: remove comment

de6c5a8

Use derived report transactions lookup for bulk pay instead of loopin…

04ef058

…g allTransactions

Merge branch 'main' into refactor/66418-remove-getReportTransactions-p8

dadde01

linhvovan29546 marked this pull request as ready for review October 14, 2026 07:39

linhvovan29546 requested review from a team as code owners October 14, 2026 07:39

melvin-bot Bot requested review from DylanDylann and flaviadefaria and removed request for a team and flaviadefaria October 14, 2026 07:39

melvin-bot Bot removed the request for review from a team October 14, 2026 07:39

DylanDylann reviewed Oct 15, 2026

View reviewed changes

Rename allTransactions to moneyReportTransactions

f95a962

DylanDylann approved these changes Oct 15, 2026

View reviewed changes

melvin-bot Bot requested a review from Julesssss October 15, 2026 05:46

Julesssss approved these changes Oct 15, 2026

View reviewed changes

Julesssss merged commit 37ea23d into Expensify:main Oct 15, 2026
36 of 39 checks passed

OSBotify mentioned this pull request Oct 16, 2026

Deploy Checklist: New Expensify 2026-10-16 #104211

Open

67 of 68 tasks

applause-bot Bot mentioned this pull request Oct 16, 2026

iOS - App freeze when select IOU expense #104270

Closed

1 of 7 tasks

MelvinBot mentioned this pull request Oct 16, 2026

Android & iOS - Spend - No skeleton loader when loading #104277

Closed

2 of 7 tasks

Conversation

linhvovan29546 commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 14, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

DylanDylann Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Oct 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

OSBotify commented Oct 15, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

OSBotify commented Oct 16, 2026

Uh oh!

MelvinBot commented Oct 16, 2026

Uh oh!

jponikarchuk commented Oct 16, 2026

Uh oh!

jponikarchuk commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jponikarchuk commented Oct 18, 2026

Uh oh!

jponikarchuk commented Oct 18, 2026

Uh oh!

jponikarchuk commented Oct 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

linhvovan29546 commented Oct 11, 2026 •

edited

Loading

codecov Bot commented Oct 11, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 14, 2026 •

edited

Loading

jponikarchuk commented Oct 16, 2026 •

edited

Loading