Skip to content

[Due for payment 2026-10-30] Expense - Not here page opens after switching to table view and deleting expense #103396

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.5-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103121
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Open the report.
  5. Click More > Switch to table view,
  6. Open the expense row.
  7. Click on the report header.
  8. Click Delete expense > Delete.

Expected Result:

Not here page will not appear after switching to table view and deleting expense.

Actual Result:

Not here page opens after switching to table view and deleting expense.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7280522_1791405901526.8.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7280522

Issue OwnerCurrent Issue Owner: @daledah

Activity

  1. applause-bot commented on Oct 7, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/9f1f71e75c0a6082fe728d633074779ad459db3c66c8a8a972289b2d24506059

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 7, 2026
  3. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #103121

  4. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    @Beamanator @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #103121

  5. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Oct 7, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. MelvinBot commented on Oct 7, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR: Add a More menu option to switch single-expense reports between expense view and table view (high confidence).

    Recommendation: revert. The revert PR is open and mergeable but needs a review: Revert "Add a More menu option to switch single-expense reports between expense view and table view".

    Root cause: The PR lets you open the only expense of a single-expense report from a table row. After you delete that expense from the details page, the details page navigates back to the report underneath. Deleting the last expense also deletes the report, so you land on the "Not here" page. See DynamicReportDetailsPage/index.tsx#L187-L217.

    Investigation details

    All links point to main at ff03a5d7, which includes the PR.

    1. The PR renders single-expense reports as a table: MoneyRequestReportUtils.ts#L172-L177.
    2. Clicking the row pushes the expense on top of the report: useNavigateToTransactionThread.ts#L112. The PR also turns off the redirect from the expense back to the report in table view: OneTransactionThreadRedirectHandler.tsx#L89-L97.
    3. Deleting the last expense also deletes the report: DeleteMoneyRequest.ts#L175-L176.
    4. The details page picks the destination before it checks whether the report is gone:
      • Wide screens: it goes back to the report panel (L210-L213).
      • Small screens: it closes the side panel and reveals the full-screen report (L215-L216).
      • Both reports were just deleted. The correct destination, the workspace chat, is computed at L233-L242 but never reached.

    Before the PR, only reports with two or more expenses had a table, so the report still existed after one deletion.

    Other PRs ruled out: Extract Report Details menu rows into self-subscribing components restructures the details page but does not change the after-delete navigation. Other checklist PRs touch unrelated code.

    Why revert rather than fix forward: The same PR caused at least six other open deploy blockers:

    The feature has no beta gate, so it affects every single-expense report.

    Fix for when the feature is re-landed (untested sketch): In navigateToTargetUrl in src/pages/DynamicReportDetailsPage/index.tsx, compute urlToNavigateBack before the side-panel branches. If it points to the parent chat (the report is being deleted), dismiss the modal and go to that chat instead of popping back to the report. Apply the same guard to the track-expense branch. Avoid navigateBackOnDeleteTransaction, because its dismissToSuperWideRHP() call lands on the deleted report again. Add tests for the wide and small-screen stacks with a one-expense report.


    view run

  9. melvin-bot commented on Oct 8, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. 19 remaining items

  11. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. mitarachim commented on Oct 21, 2026

    @mitarachim

    Deploy Blocker #104657 was identified to be related to the PR #103703 that attempted to fix this issue.

  13. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. jponikarchuk commented on Oct 22, 2026

    @jponikarchuk

    Deploy Blocker #104676 was identified to be related to the PR #103703 that attempted to fix this issue.

  16. jponikarchuk commented on Oct 22, 2026

    @jponikarchuk

    Deploy Blocker #104678 was identified to be related to the PR #103703 that attempted to fix this issue.

  17. jponikarchuk commented on Oct 22, 2026

    @jponikarchuk

    Deploy Blocker #104681 was identified to be related to the PR #103703 that attempted to fix this issue.

  18. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  19. jponikarchuk commented on Oct 22, 2026

    @jponikarchuk

    Deploy Blocker #104682 was identified to be related to the PR #103703 that attempted to fix this issue.

  20. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  21. changed the title [-]Expense - Not here page opens after switching to table view and deleting expense[/-] [+][Due for payment 2026-10-30] Expense - Not here page opens after switching to table view and deleting expense[/+] on Oct 23, 2026
  22. melvin-bot commented on Oct 23, 2026

    @melvin-bot

    @daledah

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.18-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-30. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions