Skip to content

[Due for payment 2026-10-30] Expense- Submit & More button are not disabled during bulk edit after switching to table view #103391

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.5-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #103121
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Open the report.
  5. Click More > Switch to table view.
  6. Bulk select the expense.

Expected Result:

Submit and More button should be disabled during bulk edit mode.

Actual Result:

Submit and More button are not disabled during bulk edit mode after switching to table view.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7280476_1791403789084.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7280476

Issue OwnerCurrent Issue Owner: @daledah

Activity

  1. applause-bot commented on Oct 7, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/b960c889ceb475409d91e01d97986c43222f96629330c4ef66c9f2796c34eeb8

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 7, 2026
  3. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #103121

  4. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    @Beamanator @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #103121

  5. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Oct 7, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. MelvinBot commented on Oct 7, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Causing PR (high confidence): Add a More menu option to switch single-expense reports between expense view and table view. It's in this staging deploy.

    Root cause: The header disables Submit and More only when the report is not a transaction thread (MoneyReportHeaderActions/index.tsx:59-70). It uses the raw transactionThreadReportID, which is always set for a single-expense report. The causing PR made bulk selection possible on single-expense reports through table view. It also added a table-view-aware ID (useTransactionThreadReportID.ts:29-33), but the header never uses it. So shouldDisableReportActions stays false.

    Recommendation: fix forward. The fix is a few lines in two files. Revert the PR only if the fix can't land quickly. The PR touches 34 files and adds a new account setting.

    Suggested fix: Treat the report as a transaction thread only when it isn't in table view:

    // src/components/MoneyReportHeaderActions/index.tsx
    const {shouldUseTableViewForSingleExpense} = useSingleExpenseReportView();
    const isTransactionThread = !!transactionThreadReportID && !shouldUseTableViewForSingleExpense;

    Apply the same change to MoneyReportHeaderSelectionDropdown.tsx:337. Otherwise, the "N selected" dropdown renders nothing on narrow layouts in table view:

    if (!selectedTransactionsOptions.length || (transactionThreadReportID && !shouldUseTableViewForSingleExpense)) {
        return null;
    }
    Investigation details
    • The disable behavior comes from Disable report header actions while expenses are selected, merged 2026-10-02. It intentionally skips transaction threads, because single-expense reports had no checkboxes before table view existed.
    • The header gets transactionThreadReportID from useMoneyReportTransactionThread() (index.tsx:52). That value comes from getOneTransactionThreadReportID, which ignores the view setting.
    • Submit and More both receive isDisabled={shouldDisableReportActions} (index.tsx:98, index.tsx:108).
    • The fix is safe for multi-expense reports, where transactionThreadReportID is already undefined.
    • A cleaner option: expose one isSingleExpenseView flag from MoneyReportTransactionThreadContext, so every header consumer uses the same signal.
    • Add a unit test: single-expense report, table view on, one expense selected, header actions disabled.
    • Production isn't affected, because table view doesn't exist there.

    view run

  8. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. melvin-bot commented on Oct 7, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. 19 remaining items

  11. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. mitarachim commented on Oct 21, 2026

    @mitarachim

    Deploy Blocker #104657 was identified to be related to the PR #103703 that attempted to fix this issue.

  13. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. jponikarchuk commented on Oct 22, 2026

    @jponikarchuk

    Deploy Blocker #104676 was identified to be related to the PR #103703 that attempted to fix this issue.

  16. jponikarchuk commented on Oct 22, 2026

    @jponikarchuk

    Deploy Blocker #104678 was identified to be related to the PR #103703 that attempted to fix this issue.

  17. jponikarchuk commented on Oct 22, 2026

    @jponikarchuk

    Deploy Blocker #104681 was identified to be related to the PR #103703 that attempted to fix this issue.

  18. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  19. jponikarchuk commented on Oct 22, 2026

    @jponikarchuk

    Deploy Blocker #104682 was identified to be related to the PR #103703 that attempted to fix this issue.

  20. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  21. changed the title [-]Expense- Submit & More button are not disabled during bulk edit after switching to table view[/-] [+][Due for payment 2026-10-30] Expense- Submit & More button are not disabled during bulk edit after switching to table view[/+] on Oct 23, 2026
  22. melvin-bot commented on Oct 23, 2026

    @melvin-bot

    @daledah

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.18-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-30. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions