You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-30] Expense- Submit & More button are not disabled during bulk edit after switching to table view #103391
Version Number: 9.5.5-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#103121 Email or phone of affected tester (no customers):[email protected] Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense.
Open the report.
Click More > Switch to table view.
Bulk select the expense.
Expected Result:
Submit and More button should be disabled during bulk edit mode.
Actual Result:
Submit and More button are not disabled during bulk edit mode after switching to table view.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause: The header disables Submit and More only when the report is not a transaction thread (MoneyReportHeaderActions/index.tsx:59-70). It uses the raw transactionThreadReportID, which is always set for a single-expense report. The causing PR made bulk selection possible on single-expense reports through table view. It also added a table-view-aware ID (useTransactionThreadReportID.ts:29-33), but the header never uses it. So shouldDisableReportActions stays false.
Recommendation: fix forward. The fix is a few lines in two files. Revert the PR only if the fix can't land quickly. The PR touches 34 files and adds a new account setting.
Suggested fix: Treat the report as a transaction thread only when it isn't in table view:
The disable behavior comes from Disable report header actions while expenses are selected, merged 2026-10-02. It intentionally skips transaction threads, because single-expense reports had no checkboxes before table view existed.
The header gets transactionThreadReportID from useMoneyReportTransactionThread() (index.tsx:52). That value comes from getOneTransactionThreadReportID, which ignores the view setting.
changed the title [-]Expense- Submit & More button are not disabled during bulk edit after switching to table view[/-][+][Due for payment 2026-10-30] Expense- Submit & More button are not disabled during bulk edit after switching to table view[/+]on Oct 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.18-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-30. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Oct 7, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/b960c889ceb475409d91e01d97986c43222f96629330c4ef66c9f2796c34eeb8
melvin-bot commentedon Oct 7, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #103121
melvin-bot commentedon Oct 7, 2026
@Beamanator @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #103121
melvin-bot commentedon Oct 7, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 7, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Oct 7, 2026
Deploy Blocker Analysis
Causing PR (high confidence): Add a More menu option to switch single-expense reports between expense view and table view. It's in this staging deploy.
Root cause: The header disables Submit and More only when the report is not a transaction thread (
MoneyReportHeaderActions/index.tsx:59-70). It uses the rawtransactionThreadReportID, which is always set for a single-expense report. The causing PR made bulk selection possible on single-expense reports through table view. It also added a table-view-aware ID (useTransactionThreadReportID.ts:29-33), but the header never uses it. SoshouldDisableReportActionsstaysfalse.Recommendation: fix forward. The fix is a few lines in two files. Revert the PR only if the fix can't land quickly. The PR touches 34 files and adds a new account setting.
Suggested fix: Treat the report as a transaction thread only when it isn't in table view:
Apply the same change to
MoneyReportHeaderSelectionDropdown.tsx:337. Otherwise, the "N selected" dropdown renders nothing on narrow layouts in table view:Investigation details
transactionThreadReportIDfromuseMoneyReportTransactionThread()(index.tsx:52). That value comes fromgetOneTransactionThreadReportID, which ignores the view setting.isDisabled={shouldDisableReportActions}(index.tsx:98,index.tsx:108).transactionThreadReportIDis alreadyundefined.isSingleExpenseViewflag fromMoneyReportTransactionThreadContext, so every header consumer uses the same signal.view run
melvin-bot commentedon Oct 7, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 7, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
19 remaining items
melvin-bot commentedon Oct 21, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mitarachim commentedon Oct 21, 2026
Deploy Blocker #104657 was identified to be related to the PR #103703 that attempted to fix this issue.
melvin-bot commentedon Oct 21, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 22, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Oct 22, 2026
Deploy Blocker #104676 was identified to be related to the PR #103703 that attempted to fix this issue.
jponikarchuk commentedon Oct 22, 2026
Deploy Blocker #104678 was identified to be related to the PR #103703 that attempted to fix this issue.
jponikarchuk commentedon Oct 22, 2026
Deploy Blocker #104681 was identified to be related to the PR #103703 that attempted to fix this issue.
melvin-bot commentedon Oct 22, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Oct 22, 2026
Deploy Blocker #104682 was identified to be related to the PR #103703 that attempted to fix this issue.
melvin-bot commentedon Oct 22, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Expense- Submit & More button are not disabled during bulk edit after switching to table view[/-][+][Due for payment 2026-10-30] Expense- Submit & More button are not disabled during bulk edit after switching to table view[/+]melvin-bot commentedon Oct 23, 2026
@daledah
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.18-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-30. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]