Skip to content

[Due for payment 2026-10-23] [Insights Polish] Showing tooltips on mobile devices #102865

Open

Description

@JmillsExpensify
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 2, 2026
  2. OlGierd03 commented on Oct 7, 2026

    @OlGierd03
    Contributor

    Hi! I'll be working on this one

  3. OlGierd03 commented on Oct 7, 2026

    @OlGierd03
    Contributor

    @MelvinBot

  4. added and removed on Oct 7, 2026
  5. 26 remaining items

  6. truph01 commented on Oct 20, 2026

    @truph01
    Contributor

    Deploy Blocker #104142 was identified to be related to the PR #103348 that attempted to fix this issue.

    The feature is behind a beta flag, and this is a very minor bug that real users are unlikely to encounter. See #104142 (comment)

  7. truph01 commented on Oct 20, 2026

    @truph01
    Contributor

    ⚠️ Looks like this issue was linked to a Deploy Blocker here
    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
    If a regression has occurred and you are the assigned CM follow the instructions here.
    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

    The feature is behind beta and it is minor issue, only appears if user rotating screen while the tooltip is being shown. See #104143 (comment)

  8. truph01 commented on Oct 20, 2026

    @truph01
    Contributor

    ⚠️ Looks like this issue was linked to a Deploy Blocker here
    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
    If a regression has occurred and you are the assigned CM follow the instructions here.
    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

    Not a bug. See #104187 (comment)

  9. truph01 commented on Oct 20, 2026

    @truph01
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    Precondition: account that is an admin of a workspace with expenses in the current year.

    1. Go to Spend and search type:expense group-by:category view:bar.
    2. Tap a bar and verify the tooltip shows and the search doesn't change.
    3. Tap another bar and verify the tooltip switches to it.
    4. Tap empty space in the chart and verify the tooltip hides.
    5. Change the search to view:line and view:pie and repeat steps 2–4.
    6. Go back to the view:bar search, tap a bar to show the tooltip, then start scrolling outside the chart and verify the tooltip hides and the page scrolls.
    7. Go to Home and tap the chart on the Insights card. Verify the tooltip shows and the Spend page doesn't open. Tap ⋮ > View and verify the Spend page opens.
      Do we agree 👍 or 👎
  10. truph01 commented on Oct 20, 2026

    @truph01
    Contributor

    This is part of https://github.com/orgs/Expensify/projects/317. As we can see, a few completed issues were paid at the old rate of $250.

  11. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 22, 2026
  12. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions