Skip to content

[Due for payment 2026-10-14] [Insights Polish] Line chart's line and points #102862

Closed

Description

@JmillsExpensify
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 2, 2026
  2. OlGierd03 commented on Oct 5, 2026

    @OlGierd03
    Contributor

    Hi! I'll be working on this one

  3. OlGierd03 commented on Oct 5, 2026

    @OlGierd03
    Contributor
  4. 17 remaining items

  5. OlGierd03 commented on Oct 13, 2026

    @OlGierd03
    Contributor

    Not overdue, PR has been merged

  6. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  8. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    Precondition: account with the insightsPage beta and expenses in at least a few months of the current year.

    1. Open the Insights tab.
    2. On Spend over time, verify the line is 4px wide with rounded ends and no dots are drawn on it.
    3. Hover a data point and verify the tooltip, a dot on the line and a vertical guideline appear.
    4. Hover empty space above and below the line in the same column and verify the same tooltip, dot and guideline show.
    5. Move the cursor horizontally across the chart and verify the dot and guideline follow each period.
    6. Move the cursor off the chart and verify the dot and guideline disappear without leaving a gap in the line.
    7. Click empty space in a column and verify the Spend page opens filtered to that period.
    8. Switch to dark mode and repeat steps 2–6.
    9. Open a Spend search with view:line and repeat steps 2–7.

    Do we agree 👍 or 👎

  9. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    @mallenexpensify This is part of project #317. As we can see, a few completed issues were paid at the old rate of $250.

  10. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. mallenexpensify commented on Oct 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 due $250 via NewDot

  12. garrettmknight commented on Oct 19, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions