Skip to content

[Due for payment 2026-10-14] [Insights polish] Update group-by button #102860

Closed

Description

@JmillsExpensify
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 2, 2026
  2. OlGierd03 commented on Oct 5, 2026

    @OlGierd03
    Contributor

    Hi! I'll be working on this one

  3. 16 remaining items

  4. OlGierd03 commented on Oct 13, 2026

    @OlGierd03
    Contributor

    Not overdue, PR has been merged

  5. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  6. melvin-bot commented on Oct 13, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  7. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Test:

    1. Sign in with an account that has the Insights beta.
    2. Open the Insights page.
    3. On Spend over time, verify Group by: Month has no background and shows a chevron on the right.
    4. Hover Group by: Month and verify a background appears.
    5. Click Group by: Month and verify the popover opens, the chevron flips, and the background stays while it is open.
    6. Select Week and verify the chart and the label change to Week.
    7. Verify the ⋮ button on every Insights card is 28x28px with a 12px icon and shows a background on hover.
    8. Verify the Spend over time header has the same height as the Top spenders header.
    9. Click ⋮ > View on Spend and verify the Spend page opens.
    10. Go to Home and verify the ⋮ button on the widgets is still 40x40px with a 16px icon.

    Do we agree 👍 or 👎

  8. truph01 commented on Oct 14, 2026

    @truph01
    Contributor

    @mallenexpensify This is part of project #317. As we can see, a few completed issues were paid at the old rate of $250.

  9. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. mallenexpensify commented on Oct 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @truph01 due $250 via NewDot

  11. garrettmknight commented on Oct 19, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions