Repository navigation
[Rules Engine Release 2] [App] Support expense defaults for more than just merchants #102277
Description
Now that we've migrated fully to the new rules engine, we will start supporting more filters for setting defaults, and more fields that are able to be set.
We can refer to this issue: #102273 for the shape of each rule.
Below is a mockup of the state that we want to get the expense defaults view into:
Activity
melvin-bot commentedon Sep 28, 2026
@situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-][Rules Engine Release 1] Support more expense default options[/-][+][Rules Engine Release 1] Support complex expense defaults[/+]melvin-bot commentedon Sep 30, 2026
@situchan Eep! 4 days overdue now. Issues have feelings too...
[-][Rules Engine Release 1] Support complex expense defaults[/-][+][Rules Engine Release 1] [App] Support complex expense defaults[/+][-][Rules Engine Release 1] [App] Support complex expense defaults[/-][+][Rules Engine Release 2] [App] Support complex expense defaults[/+]melvin-bot commentedon Oct 2, 2026
@situchan Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Oct 3, 2026
@situchan Still overdue 6 days?! Let's take care of this!
7 remaining items
JS00001 commentedon Oct 12, 2026
This is in progress
melvin-bot commentedon Oct 12, 2026
@situchan Huh... This is 4 days overdue. Who can take care of this?
twisterdotcom commentedon Oct 13, 2026
@JS00001 for this:
When it's multi-level tags, will we separate for every tag level, so it's:
Or is it just checking the entire tag string?
JS00001 commentedon Oct 13, 2026
We would do the same thing as search, where they can select multiple tags, which will be
OR'd with one another. These will match any tag in the list oftag1:tag2:tag3Krishna2323 commentedon Oct 14, 2026
@JS00001 Two things in the mockup that I couldn't pin down from the spec.
Merchant type: It's under "Then apply the following defaults", but today it's a condition. Merchant type rules map an MCC group to a default category via
policy.mccGroup, and the table renders them as "Merchant type is X".mccis also a search filter key. Should this move to the match section as anmccfilter? And should those MCC group rules migrate torules_as part of this, or stay where they are?Amount: I'm assuming this means
{"name": "Set", "field": "amount", "value": <number in cents>}. Let me know if the field name or units should be different.melvin-bot commentedon Oct 14, 2026
@situchan Still overdue 6 days?! Let's take care of this!
JS00001 commentedon Oct 15, 2026
@Krishna2323 sorry, for this one, lets not worry about merchant type as an action.
As for amount, if we want the amount to be $30.00, we'd set the amount value to
-3000(which is cents)Krishna2323 commentedon Oct 15, 2026
I’ve created a draft PR branched off the SetRule/DeleteRule reapply PR: #104155
JS00001 commentedon Oct 16, 2026
Nice, thanks, I'll test that one today locally
melvin-bot commentedon Oct 16, 2026
@situchan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!