You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(deps): Update NitroSQLite from 9.6.0 to 9.8.0 #101448
Update react-native-nitro-sqlite from 9.6.0 to the latest upstream code. Upstream has not published 9.8.0 yet, so [HOLD on Mobile-Expensify#14129] [Task 2/2] chore(deps): Update NitroSQLite to 9.8.0 packages upstream 4f95bbe as an unreleased 9.8.0 snapshot (a vendored tarball). When the registry release lands, the vendored artifact is swapped for the published version.
Upstream replaces our batch error-handling patch. The batch executor change in 02d7775 rolls back exactly once inside its own try, so a failing ROLLBACK no longer masks the original SQLite error — the real storage failure surfaces instead of a secondary "cannot rollback" error.
Query results are materialized once.perf: materialize query results once avoids repeated copies of the native result vector when callers traverse rows.
Opt both iOS hosts into the Application Support location via RNNitroSQLite_DatabaseLocation in their own Info.plist: standalone NewDot in App, and HybridApp in the companion PR Mobile-Expensify#14129.
Follow-up
Replace the vendored 9.8.0 snapshot with the published 9.8.0 release from npm once upstream ships it.
I've found the fix for this deploy blocker and i'm about to publish 2 new versions of NitroSQLite:
v9.8.3 is going to include just the fix. We can bump the dependency immediately to fix the deploy blocker.
v10.0.1 includes the fix + more features and performance improvements that are already being worked in this issue and this PR. The PR will still have to be reviewed and QAd separately.
Activity
chrispader commentedon Sep 17, 2026
cc @NicolasBonet
melvin-bot commentedon Oct 1, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Oct 1, 2026
Deploy Blocker #102728 was identified to be related to the PR #101437 that attempted to fix this issue.
chrispader commentedon Oct 1, 2026
Looking into the deploy blocker right now!
chrispader commentedon Oct 1, 2026
I've found the fix for this deploy blocker and i'm about to publish 2 new versions of NitroSQLite:
v9.8.3is going to include just the fix. We can bump the dependency immediately to fix the deploy blocker.v10.0.1includes the fix + more features and performance improvements that are already being worked in this issue and this PR. The PR will still have to be reviewed and QAd separately.chrispader commentedon Oct 1, 2026
Update posted in #102728 (comment)
melvin-bot commentedon Oct 1, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
chrispader commentedon Oct 1, 2026
Merging https://github.com/Expensify/Mobile-Expensify/pull/14129 will solve the deploy blocker!
1 remaining item
NicolasBonet commentedon Oct 5, 2026
Not overdue, waiting on regression period.
NicolasBonet commentedon Oct 9, 2026
Not overdue, waiting on regression period.
NicolasBonet commentedon Oct 12, 2026
Removing daily
NicolasBonet commentedon Oct 19, 2026
It looks like this passed the 3 weeks regression period, am I wrong @chrispader ?
chrispader commentedon Oct 19, 2026
@NicolasBonet yes i think we can close this out!