Include StaticRecompCore.h where the interpreter uses it - #7
Open
dougchansan wants to merge 1 commit into
Open
Conversation
unknown_instruction reads g_static_recomp_core and ppc_state, but the translation unit includes neither the header that declares the former nor a binding for the latter, so core does not compile: Interpreter.cpp(294): error C2065: 'g_static_recomp_core': undeclared identifier Interpreter.cpp(299): error C2065: 'ppc_state': undeclared identifier It is not reached through the PCH either -- pch.h does not pull in StaticRecompCore.h. The ppc_state binding already existed further down the same function, past the first use. Moving it to the top serves both uses rather than adding a second one, which would be a redefinition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coredoes not compile at themoderngekko-vendortip (7275711) with MSVC:unknown_instructionreads both, but the translation unit includes neither the header declaringg_static_recomp_core(Core/PowerPC/StaticRecomp/StaticRecompCore.h) nor a binding forppc_state. It is not reached through the precompiled header either —pch.hdoes not pull inStaticRecompCore.h.The
ppc_statebinding already existed further down the same function, past the first use. This moves it to the top so it serves both uses; adding a second one is a redefinition (C2374).Found while building
moderngekko-launcherfrom ModernGekko master. It is the second of two breaks in that path — the first is the unguarded PCH flags, already fixed on this branch, which is why this one was not visible until now.Two lines, no behaviour change.