module-template: export ppc_set_mem_write_journal - #5
Open
dougchansan wants to merge 1 commit into
Open
Conversation
The lockstep verifier resolves this symbol by name to install the module's RAM
write journal. The version script hid it, so StaticRecompLockstepVerifier::Init
printed "module lacks ppc_set_mem_write_journal export" and disabled itself --
a clean lockstep run then proved nothing at all.
macOS was unaffected: GXRuntime already marks the function
visibility("default"). Only this linker version script hid it, so the failure
was Linux-only and silent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lockstep verifier resolves this symbol by name to install the module's RAM write journal. The version script hid it, so
StaticRecompLockstepVerifier::Initprintedand disabled itself — meaning a "clean" lockstep run proved nothing at all. Silent, and the failure mode is the worst kind: it looks like success.
macOS was unaffected, since GXRuntime already marks the function
visibility("default"). Only this linker version script hid it, so the bug was Linux-only.Performance impact
None at runtime. The export only matters to
StaticRecompLockstepVerifier::Init, which runs whenSTATICRECOMP_LOCKSTEP=1. With lockstep off the symbol is never resolved.The gain is in what it unblocks: on Linux, lockstep was disabling itself and reporting nothing, so every "clean" verification run there was vacuous.