Repository navigation
Test suite improvements while converting to pytest - #170
Merged
Merged
Conversation
|
Review changes with Changed Files
|
joanise
changed the title
joanise
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 49.89% 49.89%
=======================================
Files 25 25
Lines 1980 1980
Branches 229 229
=======================================
Hits 988 988
Misses 950 950
Partials 42 42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- factor out code that is repeated many times - improve test assertions that were weak - restrict the preprocess audio fixture to just the test that needs it - other small improvements Changes made by me based on issues Claude Opus 5.5 suggested looking at.
joanise
force-pushed
the
dev.ej/convert-to-pytest
branch
from
October 15, 2026 17:56
cb9af7d to
e7e32d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EveryVoiceTTS/EveryVoice#896
Here we were already using pytest, but I've done some refactoring to improve the test suite at the same time.