[joanise]

PR Goal?

In some cases, installing ffmpeg during the conda create call gave us an ffmpeg missing some libraries.

Installing it in a subsequent conda install step is more reliable.

Fixes?

bug report by MT on our clusters

Feedback sought?

make sure it works now on the clusters where ffmpeg was incorrectly installed.

Priority?

low

Tests added?

no

How to test?

usually install using conda followed by

pytest everyvoice/model/aligner/wav2vec2aligner/aligner/tests/test_cli.py

which failed before (on the problem clusters) with a log including this line

ffmpeg output: b'' b'ffmpeg: error while loading shared libraries: libx264.so.138: cannot open shared object file: No such file or directory\n'

but should now pass.

Confidence?

high

Version change?

no

Related PRs?

no

[semanticdiff-com]

Review changes with  

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.25%. Comparing base (0f7443c) to head (2ad9d7d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files          51       51           
  Lines        4789     4789           
  Branches      712      712           
=======================================
  Hits         4083     4083           
  Misses        534      534           
  Partials      172      172           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

CLI load time: 0:00.23
Pull Request HEAD: 2ad9d7d536662504989cd4a25e008bb360b07839

Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      7682 |     220515 | everyvoice.cli
import time:      5195 |     115791 |   rich.markdown
import time:      4897 |     210640 | typer.rich_utils

[marctessier]

Look Good now on GPSC. Thanks!
I am now getting this when I run the full pytest on PR899 :
== 408 passed, 1 skipped in 321.36s (0:05:21) ==

I was getting:
=== short test summary info ===
SUBFAILED[ctc-segmenter align] everyvoice/model/aligner/wav2vec2aligner/aligner/tests/test_cli.py::TestCLI::test_align_something
SUBFAILED[ctc-segmenter extract] everyvoice/model/aligner/wav2vec2aligner/aligner/tests/test_cli.py::TestCLI::test_align_something
FAILED everyvoice/model/aligner/wav2vec2aligner/aligner/tests/test_cli.py::TestCLI::test_align_something
=== 3 failed, 407 passed, 1 skipped in 315.83s (0:05:15) ===