Repository navigation
Add tests for structured Reddit output - #17
Conversation
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds tests for structured Reddit link and self-post artifacts, verifies Reddit artifacts in plan JSON, and updates CI permissions, credential persistence, and workspace line-coverage enforcement. ChangesReddit artifact coverage
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 40-49: Restrict the coverage job’s permissions by adding job-level
contents: read, and configure the actions/checkout@v4 step with
persist-credentials disabled. Apply these changes only to the coverage job so
cargo llvm-cov and repository tests cannot access a write-capable persisted
token.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 11985f51-712d-4967-b70d-9b69cb3b708a
📒 Files selected for processing (3)
.github/workflows/ci.yamlsrc/plan.rssrc/renderers/reddit.rs
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Line 23: Move persist-credentials: false from the
dtolnay/rust-toolchain@stable configuration to the preceding checkout step at
.github/workflows/ci.yaml lines 23-23, 34-34, and 55-55; remove it from each
Rust toolchain configuration and add it to each corresponding checkout step.
- Around line 43-44: The standalone with mappings in .github/workflows/ci.yaml
at lines 43-44 and 73-74 are invalid workflow steps; remove them and attach
persist-credentials: false directly under the corresponding actions/checkout@v4
step in both the test and build jobs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5deb5655-c9f2-4dc5-bf13-e85e61e1afd5
📒 Files selected for processing (1)
.github/workflows/ci.yaml
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| components: rustfmt | ||
| persist-credentials: false |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major
Move persist-credentials: false to the checkout steps.
dtolnay/rust-toolchain@stable does not accept this input, so checkout credentials remain persisted. Apply the setting at each checkout site:
.github/workflows/ci.yaml#L23-L23: remove it from the Rust toolchain configuration and add it under the preceding checkout step..github/workflows/ci.yaml#L34-L34: make the same change in the clippy job..github/workflows/ci.yaml#L55-L55: make the same change in the coverage job.
🧰 Tools
🪛 actionlint (1.7.12)
[error] 23-23: input "persist-credentials" is not defined in action "dtolnay/rust-toolchain@stable". available inputs are "components", "target", "targets", "toolchain"
(action)
📍 Affects 1 file
.github/workflows/ci.yaml#L23-L23(this comment).github/workflows/ci.yaml#L34-L34.github/workflows/ci.yaml#L55-L55
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ci.yaml at line 23, Move persist-credentials: false from
the dtolnay/rust-toolchain@stable configuration to the preceding checkout step
at .github/workflows/ci.yaml lines 23-23, 34-34, and 55-55; remove it from each
Rust toolchain configuration and add it to each corresponding checkout step.
Source: Linters/SAST tools
Summary
Adds tests for structured Reddit output to avoid regression. Specifically tests cover the following cases:
plan --jsoncontains the structured Reddit artifact/r/andr/to prefix-less in the plan/render structureThis PR also introduces a CI check that coverage remains above 70%.
Closes #3
Summary by CodeRabbit