Skip to content

Fix async Bukkit access in spawn and other commands #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YoshiroMaximus wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix async Bukkit access in spawn and other commands #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc31c28
fixed /spawn command
YoshiroMaximus Oct 13, 2026
da34a0b
Merge branch 'master' of https://github.com/YoshiroMaximus/EternalCore
YoshiroMaximus Oct 13, 2026
58e2baa
fixed other async commands
YoshiroMaximus Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions eternalcore-core/src/main/java/com/eternalcode/core/EternalCoreCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import com.eternalcode.core.publish.Publisher;
import com.eternalcode.core.publish.event.EternalReloadEvent;
import com.google.common.base.Stopwatch;
import dev.rollczi.litecommands.annotations.async.Async;
import dev.rollczi.litecommands.annotations.command.Command;
import dev.rollczi.litecommands.annotations.context.Sender;
import dev.rollczi.litecommands.annotations.execute.Execute;
Expand Down Expand Up @@ -34,7 +33,6 @@ class EternalCoreCommand {
this.publisher = publisher;
}

@Async
@Execute(name = "reload")
@DescriptionDocs(description = "Reloads EternalCore configuration")
void reload(@Sender Audience audience) {
Expand Down
4 changes: 0 additions & 4 deletions eternalcore-core/src/main/java/com/eternalcode/core/feature/jail/JailCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import com.eternalcode.core.notice.NoticeService;
import com.eternalcode.core.util.DurationUtil;
import dev.rollczi.litecommands.annotations.argument.Arg;
import dev.rollczi.litecommands.annotations.async.Async;
import dev.rollczi.litecommands.annotations.command.Command;
import dev.rollczi.litecommands.annotations.context.Sender;
import dev.rollczi.litecommands.annotations.execute.Execute;
Expand Down Expand Up @@ -39,7 +38,6 @@ class JailCommand {
this.server = server;
}

@Async
@Execute(name = "setup")
@Permission("eternalcore.jail.setup")
@DescriptionDocs(description = "Define jail spawn area")
Expand All @@ -57,7 +55,6 @@ void executeJailSetup(@Sender Player player) {
.send();
}

@Async
@Execute(name = "setup")
@Permission("eternalcore.jail.setup")
@DescriptionDocs(description = "Define jail spawn area", arguments = "<location>")
Expand All @@ -75,7 +72,6 @@ void executeJailSetup(@Sender Player player, @Arg Location location) {
.send();
}

@Async
@Execute(name = "remove")
@Permission("eternalcore.jail.setup")
@DescriptionDocs(description = "Remove jail spawn area")
Expand Down
2 changes: 0 additions & 2 deletions eternalcore-core/src/main/java/com/eternalcode/core/feature/setslot/SetSlotCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import com.eternalcode.core.notice.NoticeService;
import com.eternalcode.core.viewer.Viewer;
import dev.rollczi.litecommands.annotations.argument.Arg;
import dev.rollczi.litecommands.annotations.async.Async;
import dev.rollczi.litecommands.annotations.command.Command;
import dev.rollczi.litecommands.annotations.context.Sender;
import dev.rollczi.litecommands.annotations.execute.Execute;
Expand All @@ -28,7 +27,6 @@ public SetSlotCommand(
}

@Execute
@Async
@DescriptionDocs(description = "Set the max players on the server")
public void execute(@Sender Viewer viewer, @Arg int slots) {
if (slots <= 0) {
Expand Down
2 changes: 0 additions & 2 deletions eternalcore-core/src/main/java/com/eternalcode/core/feature/spawn/SetSpawnCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import com.eternalcode.annotations.scan.command.DescriptionDocs;
import com.eternalcode.core.injector.annotations.Inject;
import com.eternalcode.core.notice.NoticeService;
import dev.rollczi.litecommands.annotations.async.Async;
import dev.rollczi.litecommands.annotations.command.Command;
import dev.rollczi.litecommands.annotations.context.Sender;
import dev.rollczi.litecommands.annotations.execute.Execute;
Expand All @@ -26,7 +25,6 @@ class SetSpawnCommand {
this.spawnService = spawnService;
}

@Async
@Execute
@DescriptionDocs(description = "Set spawn location")
void execute(@Sender Player player) {
Expand Down
3 changes: 2 additions & 1 deletion eternalcore-core/src/main/java/com/eternalcode/core/feature/spawn/SpawnServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public Location getSpawnLocation() {
}

private boolean isSpawnValid() {
return !this.locationsConfiguration.spawn.isNoneWorld();
return this.locationsConfiguration.spawn != null
&& !this.locationsConfiguration.spawn.isNoneWorld();
}
}