Skip to content

fix: surface Pi graph errors and deliver reminders between steps - #42

Merged
Epsirom merged 1 commit into
mainfrom
chrok/pi-errors-step-reminders
Oct 4, 2026
Merged

Epsirom merged 1 commit into
mainfrom
chrok/pi-errors-step-reminders

Conversation

@Epsirom

@Epsirom Epsirom commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Change

Pi could display failed graph submissions as jobs with undefined IDs, hide the output requested by a focused status read, and hold pause/completion reminders until the entire foreground task ended. This makes errors visible and delivers reminders after the current assistant response and tool batch so the parent can handle pauses during ongoing work.

  • Clarify node, template, loop, and revision parameters while retaining a flat provider-facing node schema. Echo accepted graph types/policies and explain atomic update failures and complete-patch retries.
  • Render submission/status errors and selected execution output, include current control fields alongside historical execution data, and clear resumable holds when a graph finalizes.
  • Preserve complete running status snapshots and failed-worker Pi usage in exported results, without claiming usage early when a snapshot write races completion.
  • Supply optional mergeSources[].changes.baseCommit metadata for cumulative diffs after read-only reviews, and explain how to handle multi-parent checkpoints. Regression coverage verifies integration preserves staged, unstaged, and untracked caller edits.

Validation

  • npm run verify: 227 core tests and 90 Pi tests pass, plus both type checks, offline examples, and external tarball installation/build checks.

  • Real Pi host fixtures verify reminders during model responses and tool batches, without skipping tools, plus idle continuation and acknowledgement behavior. Additional host/schema checks passed with Pi 1.0.2.

  • Kimi K3 parameter-generation smoke preserved all requested node fields. A reviewed Pi 1.0.2/Kimi K3 session completed parallel worktrees, atomic update/resume, read-only acceptance, integration, and an optional-failure/cancel probe; its generated project passed 17 tests. No session transcripts or provider outputs are included.

  • Live coverage did not exercise feedback retries or the final cumulative-baseline addition; these are covered by deterministic runtime/Git regressions.

  • Relevant tests and type checks pass.

  • User-facing docs and changelog are updated.

  • Compatibility reviewed: diagnostic metadata is additive and the new public field is optional; no breaking changes in this PR.

Not a release PR.

@Epsirom
Epsirom merged commit 8ec1cb3 into main Oct 4, 2026
11 checks passed
@Epsirom
Epsirom deleted the chrok/pi-errors-step-reminders branch October 4, 2026 09:55
@Epsirom Epsirom mentioned this pull request Oct 4, 2026
4 tasks done
Epsirom added a commit that referenced this pull request Oct 4, 2026
## Change

Prepare matching `@chrok/braid` and `@chrok/pi-braid` 0.3.0 releases
from #41 and #42. This minor version accounts for writable Pi shell
tools and Git-aware checkpoint semantics; it also includes Pi graph
diagnostics, focused status/usage exports, cumulative merge-source
baselines, and reminders between model steps.

Update both manifests, Pi's exact core dependency, and the workspace
lockfile. Finalize the changelog with implementing PR links and author
credits, document 0.2 → 0.3 migration, and align both READMEs and the
roadmap. Both included PRs are by @Epsirom, whose earlier contributions
were verified; there are no first-time human contributors.

## Validation

- `npm ci` and `npm run verify`: 227 core tests, 90 Pi tests, both type
checks, offline examples, and isolated tarball checks passed. The
package smoke verifies public imports, declarations, transitive core
installation, and a Pi background job outside the checkout.
- `npm pack --dry-run` for both packages: inspected clean file lists,
licenses, and 0.3.0 versions; core has 39 files and Pi has 11.
- `RELEASE_TAG=v0.3.0 node scripts/check-release.mjs` and `git diff
--check` passed.
- Hosted CI and CodeQL must pass before merge/tag. Publication will use
the existing trusted-publishing workflow, followed by exact-version,
latest-tag, provenance, and clean registry installation checks.

- [x] Relevant tests and type checks pass.
- [x] User-facing docs and changelog are updated where needed.
- [x] Breaking changes include migration guidance.
- [x] Release notes link feature/fix PRs, credit authors, and identify
first-time contributors per the release guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant