Support ! negations in pure-Oot gitignore matcher - #10
Merged
Conversation
build_ignore_state kept dropping ! lines. simple_ignored now folds rules in order, last match wins. File-level negations match git check-ignore exactly, dir re-inclusion is a documented forgiving superset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure-Oot projects dropped ! lines entirely. Now last-match-wins like git. File negations verified against git check-ignore as oracle. Dir re-inclusion under excluded dirs is a documented forgiving superset (git refuses, we honor). One file, 74 insertions, all 18 test suites green, clippy and fmt clean.