You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Major question/concern: Order of operations for applying filters will affect the results. Currently, the filters are applied in steps Fraction, Fragment, and then Taxonomy. Which sequences that pass the Fraction filter is a bit random and certainly uncaring to the biology; that filter just blindly removes based on a modulo boolean check. Whatever sequences remain may still not pass the other filters. This has the potential to really hamstring an analysis.
Applying the Fraction filter last, would enable the other filters to thoroughly remove the biologically uninteresting sequences, leaving behind a set of sequences that we know the user is interested in, from which the Fraction filter can remove sequences in a more random, uncaring fashion.
But, changing the order of filtering operations will/may return different results compared to those from the EFI v1 code base.
Given the same ordering of IDs, this [filter] will be deterministic. But, if the ordering changes (whether due to change in the EFI-DB version or some nuance of querying), recreating the same fractioning of the input IDs may not be recovered exactly. Should we add some text disclaimer about this on the frontend?
What happens if the $opts->{fraction} value is larger than the total number of members in the family? Do we throw a warning message saying only one sequence was gathered from the set?
Activity
rbdavid commentedon Apr 17, 2025
Refering to the Fraction filter specifically:
Originally posted by @rbdavid in #151 (comment)
rbdavid commentedon Apr 17, 2025
Referring to the Fraction filtering:
Originally posted by @rbdavid in #151 (comment)