Preserve projection metadata across data source pushdown - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectionExecwhen a data source pushdown cannot preserve its exact output schemaMemorySourceConfigWhy
DataSource::try_swapping_with_projectionreceives projection expressions but not the projection output schema. A source can therefore absorb an otherwise identity projection while dropping field metadata. The physical optimizer then changes the planned schema and fails its invariant check.The guard is conservative: normal pushdown is unchanged when the resulting schema is identical.
Validation
cargo +1.95.0 test --offline -p datafusion --test core_integration physical_optimizer::projection_pushdown(24 passed)cargo +1.95.0 clippy --offline -p datafusion-datasource --lib -p datafusion --test core_integrationcargo +1.95.0 fmt --all -- --check