PushConstant not being OpTypeStruct is invalid on Vulkan hosts #362

Activity

1. hrydgard

   added

   t: bugSomething isn't workingSomething isn't working

   on Jan 4, 2021
2. XAMPPRocky commented on Jan 5, 2021

   

   XAMPPRocky

   on Jan 5, 2021

   Last edited by XAMPPRocky

   Member

   More actions

   Thank you for your issue! While I'm not doubting that is the case, I cannot find any reference in the SPIR-V spec that lays out that requirement. Perhaps they could expand further? @baldurk

   The closest thing I could find is the following:

   Composite objects in the UniformConstant, Uniform, and PushConstant Storage Classes must be explicitly laid out. The following apply to all the aggregate and matrix types describing such an object, recursively through their nested types

   Where composite is defined as "An aggregate, a matrix, or a vector.", which would imply to me that this is not a requirement for those storage classes containing scalars.
3. msiglreith commented on Jan 5, 2021

   

   msiglreith

   on Jan 5, 2021

   Contributor

   More actions

   @XAMPPRocky That's probably referred to using Vulkan as host which comes with its own set of requirements and constraints:
   https://vulkan.lunarg.com/doc/view/1.2.131.1/mac/chunked_spec/chap14.html#interfaces-resources-pushconst
4. hrydgard commented on Jan 5, 2021

   

   hrydgard

   on Jan 5, 2021

   Last edited by hrydgard

   ContributorAuthor

   More actions

   That's a good catch @msiglreith !

   Given how we want to use rust-gpu, having an option to, or at least initially, always following Vulkan's extra rules seems like the way to go.
5. XAMPPRocky

   changed the title [-]Slightly invalid SPIR-V (PushConstant not OpTypeStruct), according to BaldurK[/-] [+]PushConstant not being OpTypeStruct is invalid on Vulkan hosts[/+] on Jan 5, 2021
6. XAMPPRocky

   added

   a: vulkanIssues specifically about Vulkan.Issues specifically about Vulkan.

   c: rustc_codegen_spirvIssues specific to the rustc_codegen_spirv crate.Issues specific to the rustc_codegen_spirv crate.

   on Jan 5, 2021
7. XAMPPRocky

   added

   a: push constantIssues related to push constants.Issues related to push constants.

   on Mar 24, 2021
8. khyperia commented on Oct 28, 2021

   

   khyperia

   on Oct 28, 2021

   Contributor

   More actions

   I believe this was fixed by two things:

   1. ABI rewriting shenanigans of rustc taking a push constant struct and replacing it with a scalar - fixed by abi: readjust FnAbis to remove unsupported PassModes, via query hooks. #766
   2. Push constants being used directly instead of structs (i.e. #[spirv(push_constant)] asdf: &f32) - fixed by wrapping everything in a struct Deprecate #[spirv(block)] and auto-wrap in "interface blocks" instead. #576
9. khyperia

   closed this as completedon Oct 28, 2021