Resume filter validation from its own CSV after a crash - #451
Open
luciaquirke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filter validation run is one from-scratch retrain per query — hours of work at larger corpora — and the per-query CSV is already written incrementally, but an interrupted run had no way to continue: with resume the query loop restarted from zero, and without it the existing run_path is refused entirely.
This reads the method CSV back on startup, re-emits the measured rows, and skips their retrains. The CSV is read on every rank (not just rank 0) so the distributed retrain loop stays in step. A crash now costs one query's retrain instead of the whole run; measured under repeated shared-volume outages, where each interruption previously discarded up to 2.5 h.
🤖 Generated with Claude Code
https://claude.ai/code/session_0167XKnE2yoCE162n3jHvxC1