Fix resume skipping an interrupted Hessian fit - #449
Open
luciaquirke wants to merge 1 commit into
Open
Conversation
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The step-2 resume check tests
_step_complete(hessian_path), but the fit runs withrun_path = {hessian_path}/{method}and promotes{hessian_path}/{method}.part -> {hessian_path}/{method}. Creating the .part directory also creates the parenthessian/, so after any interruption the parent exists,step_statereports complete, and a resumed run skips the unfinished fit — step 3 then crashes on missing factors (or, with a stale partial method dir, silently applies an incomplete Hessian).Hit in practice when a shared volume filled mid-fit: every resumed pipeline jumped to apply_hessian and died with
apply_hessian child exited with code 1; the only recovery was deletinghessian/by hand and refitting from scratch.Fix: check the path the fit actually promotes,
{hessian_path}/{method}— the same path step 3 reads.🤖 Generated with Claude Code
https://claude.ai/code/session_0167XKnE2yoCE162n3jHvxC1