Repository navigation
Fix CI configure with CMake 4 and current Windows runners - #13
Merged
Merged
Conversation
Update googletest to v1.12.1, the last release supporting C++11, whose CMake minimum (3.5) is accepted by CMake 4. Stop forcing the Visual Studio 2019 generator, which windows-latest no longer provides, and update the checkout and setup-msbuild actions. Fixes #11 Co-authored-by: Copilot <[email protected]> Copilot-Session: 3eaf20ea-3ac0-4701-958f-28527bf641fc
The test step only looked for build/bin/pbamtest, so the Windows Release/*.exe binaries were silently skipped. Co-authored-by: Copilot <[email protected]> Copilot-Session: 3eaf20ea-3ac0-4701-958f-28527bf641fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11.
-std=c++11). Itscmake_minimum_required(VERSION 3.5)is accepted by CMake 4, so the macOS configure works again.-G "Visual Studio 16 2019"from the Windows configure, becausewindows-latestno longer has VS 2019. CMake now selects the installed Visual Studio;-A Win32is kept so the x86 vcpkg dependencies still match.actions/checkout@masterto@v5andmicrosoft/[email protected]to@v2.googletest is fetched only when
ENABLE_PB_TESTING=ON, so APBS builds of PBAM/PBSAM are unaffected.Testing
pbamtestpassed 160 tests andpbsamtestpassed 102.