Repository navigation
Make Windows release package independent of Python - #327
Merged
Merged
Conversation
Disable PyGBe in the Windows build so apbs.exe no longer imports an unbundled pythonXY.dll, and stop installing Python before the Windows usage test so missing DLLs fail CI. Refs #301 Co-authored-by: Copilot <[email protected]> Copilot-Session: 3eaf20ea-3ac0-4701-958f-28527bf641fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows release
apbs.exelinks againstpython3XY.dllbecause PyGBe is enabled, but that DLL is not bundled.On machines without the matching 32-bit Python, APBS fails to start with
0xC0000135(STATUS_DLL_NOT_FOUND), as reported in #301 for 3.4.0 (python39.dll).The Windows usage test hid this because it installed Python before running the package.
Changes:
ENABLE_PYGBE=OFF, matching the arm64 macOS package.setup-pythonstep from the usage tests so CI verifies the package is self-contained.Linux and Intel macOS packages still include PyGBe.
Refs #301