Repository navigation
use conventions for axes - #223
Merged
Merged
Conversation
make sure everything remains float32
convenience function for finding the average detection point
KrisThielemans
commented
Oct 30, 2026
- use z,y,x ordering to be consistent with DetectorModule - adapt (and actually fix) is_lex_less - add some py.test files and run in CI
github-project-automation
Bot
moved this from In progress
to Done
in (logical) elements, terminology etc for v1
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of changes
BoxShapeandDetectorModuleget_ADP(convenience function for finding the average detection point)ostream<<overloads for easier printingImportant note
The restrictions and order imposed are compatible with the previously existing helpers to construct the scanner.
Fixes #98
Fixes #148
Fixes #170