Repository navigation
fix(oidc): show pending state before returning from profile - #1495
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user saves their display name and immediately continues to Civio, the hosted profile page silently blocks navigation until the request finishes. The return link now shows whether the name is saving or loading, and an attempted click explains the wait. The normal link returns when the request finishes; unsaved-input confirmation and uncertain-save recovery remain in place.
Validation: headed Chrome preview against the real provider API, holding save/read requests to inspect pending feedback and then allowing actual responses; clean return and dirty-input cancellation verified. JavaScript syntax and diff checks passed. One fixed-diff review completed. Linux build and deployed browser verification are recorded separately. No API or schema changes.
Refs #1385. Related Civio first-administrator onboarding: encryptixio/civio#455.