Skip to content

Multiple radiation bug fixes spotted by Claude #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpaiao wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Multiple radiation bug fixes spotted by Claude #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e47498b
Update twostream_rad.f90
mpaiao Jul 30, 2026
712acd4
Update radiate_driver.f90
mpaiao Jul 30, 2026
ec232fc
Update radiate_driver.f90
mpaiao Jul 30, 2026
cbf7452
Update twostream_rad.f90
mpaiao Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ED/src/dynamics/radiate_driver.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ subroutine sfcrad_ed(cosaoi,csite,ipa,ibuff,mzg,mzs,ntext_soil,ncol_soil,rlong,t
albedo_soil_nir = soilcol(colour)%alb_nir_dry
!----- Damp soil, for temporary surface water albedo. ----------------------------!
albedo_damp_par = albedo_soil_par
albedo_damp_nir = albedo_damp_nir
albedo_damp_nir = albedo_soil_nir
case (12)
!----- Peat, follow McCumber and Pielke (1981). ----------------------------------!
fcpct = csite%soil_water(mzg,ipa) / soil(nsoil)%soilpo
Expand Down Expand Up @@ -1104,9 +1104,11 @@ subroutine sfcrad_ed(cosaoi,csite,ipa,ibuff,mzg,mzs,ntext_soil,ncol_soil,rlong,t
* radscr(ibuff)%LAI_array(il) &
+ (1.d0 - wood_scatter_nir(ipft)) &
* radscr(ibuff)%WAI_array(il) ), tiny_offset )
wleaf_tir = sngloff( ( leaf_emiss_tir(ipft) &
wleaf_tir = sngloff( ( clumping_factor(ipft) &
* leaf_emiss_tir(ipft) &
* radscr(ibuff)%LAI_array(il) ) &
/ ( leaf_emiss_tir(ipft) &
/ ( clumping_factor(ipft) &
* leaf_emiss_tir(ipft) &
* radscr(ibuff)%LAI_array(il) &
+ wood_emiss_tir(ipft) &
* radscr(ibuff)%WAI_array(il) ) &
Expand Down
4 changes: 3 additions & 1 deletion ED/src/dynamics/twostream_rad.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ subroutine sw_two_stream(grnd_alb_par4,grnd_alb_nir4,cosaoi4,nir_beam_norm
! longwave radiation. !
!------------------------------------------------------------------------------!
mu (i) = - etai(i) / log( ( 1.d0 - cai(i) ) &
+ cai(i) * exp( - etai(i) / mu_bar(ipft) ) )
+ cai(i) * exp( - etai(i) / (cai(i) * mu_bar(ipft) ) ) )
!------------------------------------------------------------------------------!


Expand Down Expand Up @@ -654,6 +654,8 @@ subroutine sw_two_stream(grnd_alb_par4,grnd_alb_nir4,cosaoi4,nir_beam_norm
! Find the diffuse radiation properties. !
!---------------------------------------------------------------------------------!
diffuseloop: do i=1,ncoh
ipft = pft(i)

!----- Scattering coefficient. ------------------------------------------------!
iota (i) = leaf_weight(i) * leaf_scatter(ipft) &
+ wood_weight(i) * wood_scatter(ipft)
Expand Down
Loading