Repository navigation
chore(upstream): pin Gentleman.Dots 5b13e07 and verify stale pins by fetching them - #27
Merged
Merged
Conversation
…fetching them Gentleman.Dots has one new commit (a two-line nvim obsidian picker fix); move the pin, the sources table and the test fixture. While verifying it, --check-pins turned out to be unable to check any pin that is no longer the remote HEAD: it ran git ls-remote <url> <sha>, which matches ref names, never hashes, so it always exited 2. It went unnoticed while every pin equalled HEAD. Fetch the hash into a throwaway bare repo instead (as the diff already does) and forbid the ref-name lookup in a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin. Gentleman.Dots has one new commit (
5b13e07, a two-line fix of the nvim obsidian picker name); the pin, the sources table and the test fixture move to it. ML4W stays on tag 2.16 (its remote HEAD is ahead with unreleased commits; reported as drift only).Defect found while verifying it.
upstream-diff.py --check-pinscould not check any pin that was no longer the remote HEAD: it rangit ls-remote <url> <sha>, which matches ref names, never hashes, so it always exited 2 ("Git exited 2"). It went unnoticed while every pin equalled HEAD. Reachability is now checked by fetching the pinned hash into a throwaway bare repo (the mechanism the diff already uses); a regression test forbids the ref-name lookup. Live result against the real remotes: Gentleman.Dots current, ML4W stale-but-reachable.Tests: check-pins tests rewritten to the real behaviour, pytest exit 0, bats 192 ok, ruff and mypy clean. Includes the ODD feature document for this bump (Herdr 0.9.3 follows in its own PR).