Repository navigation
feat(gga): do not block commits when the review provider is unavailable - #23
Merged
Merged
Conversation
The pin sends every gga review to Codex, and the quota is shared across models (gpt-6-sol hits the same usage limit), so a model fallback would not help. With STRICT_MODE=true a provider failure makes gga exit 1 and blocks every commit until the quota resets. Set STRICT_MODE=false in the marked block, which survives gentle-ai sync: a real STATUS: FAILED still blocks, an unavailable provider does not, and gga never reports PASSED for a review that did not run. Projects that set STRICT_MODE=true themselves keep blocking; documented in docs/configuration/gga.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin sends every gga review to Codex, and the Codex quota is shared across models (measured:
gpt-6-solhits the sameusage_limit_exceededasgpt-6.1-sol), so a model fallback would not help. WithSTRICT_MODE=truea provider failure makes ggaexit 1, which would block every commit in the ~31 repositories that use strict mode until the quota resets.The marked block in the global gga config (it survives
gentle-ai sync) now setsSTRICT_MODE="false": a realSTATUS: FAILEDfrom the reviewer still blocks, an unavailable provider does not, and gga never reportsPASSEDfor a review that did not run. Repositories whose own.ggasetsSTRICT_MODE="true"override the global value and keep blocking during an outage; this is documented indocs/configuration/gga.mdtogether with thegit commit --no-verifyescape.New bats test (fails without the change): a gentle-ai-style config with
STRICT_MODE="true"ends up non-strict after the installer. bats 186 ok. Observed on this very commit: Codex failed on quota and the commit went through.