Repository navigation
fix(gga): put the pin shim ahead of the real codex in fish - #22
Merged
Merged
Conversation
fish keeps fish_user_paths ahead of the rest of PATH, and config.fish adds ~/.local/bin (where the real codex lives) to it. The shim directory was added with --path from a conf.d snippet, so in a fresh shell it sat at position 8 behind the real codex at 6: the model pin then relied only on the block in the gga config, which gentle-ai sync rewrites. Add the shim directory to fish_user_paths from config.fish, after the other fish_add_path calls, and move it to the front. The conf.d snippet now only exports GGA_PROVIDER. A test checks the order (it fails without the change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a fresh fish the GGA pin shim sat at PATH position 8, behind the real
codexat 6, so the model pin relied only on the block in~/.config/gga/config, whichgentle-ai syncrewrites (found while simulating that rewrite).Cause: fish keeps
fish_user_pathsahead of the rest of PATH, andconfig.fishadds~/.local/bin(the real codex) to it. The shim was added with--pathfrom a conf.d snippet that runs beforeconfig.fish.Fix: add the shim directory to
fish_user_pathsfromconfig.fish, after the otherfish_add_pathcalls, and move it to the front (--move). The conf.d snippet now only exportsGGA_PROVIDER. New bats test checks the order and fails without the change (RED confirmed). zsh and bash were already correct.