Repository navigation
fix(ml4w): make verify-ml4w-setup robust and recognise linked ML4W directories - #19
Merged
Merged
Conversation
…rectories - path_is_ml4w_managed: a file inside a directory symlinked into the ML4W dotfiles is managed (ML4W 2.16 links whole app dirs), removing three false 'regular file' warnings - verify passes paths to inline Python through argv instead of interpolating them, and says when schema validation is skipped for lack of jsonschema - a missing jq is reported as skipped instead of as Hyprland not running or invalid JSON - share helpers for the wlogout and swaync colour links, the profile paths and the dreamcoder symlink check - AGENTS.md: scripts set strict mode, sourced files must not, drop the unworkable 30-line rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live
verify-ml4w-setup.shgoes from 20 passed / 4 warnings to 23 passed / 1 warning (the remaining one is the genuine uncommitted-changes notice).path_is_ml4w_managed: a file inside a directory symlinked into the ML4W dotfiles is managed. ML4W 2.16 links whole app directories, so rofi, wlogout and swaync configs were reported as regular files.ML4W_DOTFILES_DIRrelocates the root.argvinstead of being interpolated into source (a quote in the path broke schema validation and could inject code); a missingjsonschemais now reported instead of silently skipping the check.jqis reported as skipped instead of as Hyprland not running or invalid JSON.AGENTS.md: executable scripts set strict mode, sourced files must not, and the unworkable 30-line rule is dropped. With GGA now running on gpt-6.1-sol these rules are enforced for real, so they must be satisfiable.Tests: 8 new bats tests (5 predicate, 3 verify robustness); bats 107/107.