Repository navigation
ci: give the ML4W dry-run job a simulated ML4W install - #17
Merged
Merged
Conversation
The full dry-run job failed on every run because its pre-flight requires an ML4W install and the runner has none. Create the two marker files the ownership predicates look for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Full dry-runjob ofML4W Setup Testshas failed on every run since at least July: itspre-flight requires an ML4W install (
Hyprland config is ML4W-managed) and the GitHub runner hasnone. A workflow that is always red hides real regressions.
Changes
lib/ml4w.shlook for(
~/.config/hypr/conf/keybinding.luaand~/.config/waybar/launch.sh) before the dry-runs.Verification
Reproduced locally with a temporary
HOME: without the stepsetup-hyprland.sh --profile default --dry-runexits 1; with it,setup-hyprland.shandgenerate-custom-lua.shdry-runs exit 0 forboth the
defaultandasus-vivobook15profiles.Scope