Repository navigation
chore(quality): complexity refactors, stricter gates and fixes from the quality pass - #16
Merged
Merged
Conversation
…ze to super+ctrl+arrows The variant resized and the profile moved windows on the same combos, so both fired. The profile documents that it owns move-window, so the variant's resize moves to the free SUPER+CTRL+arrows. The collision test now allows no exceptions and pins the resize binds.
Measured coverage is 83%; a floor of 40% let a 40-point regression through. Update pyproject, the CI job and ADR-0003 together.
A single local statement expands dir before file is assigned in bash (SC2318), so extract archive.zip used an empty directory. Split the assignments and cover the default, explicit and unknown-type cases.
CI and pre-commit skipped lib/ and DreamcoderShell/, which is how the extract() SC2318 bug shipped. Third-party skill scripts stay out of scope.
Compose WCAG text tokens, main text, foreground pairs, ANSI, APCA classes and structural checks as small pure helpers in the original order. Every error string and its position is unchanged (pinned by the characterization test); radon cc drops from E (34) to B (6).
Split evaluate_contract into mode/role, render, parity (provenance and required roles) and matrix helpers composed in the original order, and replace the _parse_renderer_output if-chain with a per-target parser table. Findings, messages and sort order are unchanged; radon cc goes from D (26) to A (1) and from D (21) to A (2).
Cover the missing-bg KeyError, the ANSI derivation failing without text, and the skipped WCAG check for an absent foreground-pair token.
main() ignored sys.argv, so dreamcoder sync --help ran a full sync against the live configuration. Parse first: --help prints usage and exits 0, unknown options exit 2, and tests inject argv explicitly.
4 tasks done
Dreamcoder08
force-pushed
the
pr/05-remove-night-profile
branch
from
September 29, 2026 18:47
4db6695 to
f353575
Compare
Dreamcoder08
force-pushed
the
pr/06-quality-pass
branch
from
September 29, 2026 18:47
4ce5c18 to
3d7c826
Compare
Dreamcoder08
changed the base branch from
pr/05-remove-night-profile
to
main
September 29, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measured baseline: mypy --strict clean, coverage 83%, no known dependency vulnerabilities. This slice attacks the real hotspots and closes gate gaps that let bugs through.
Changes
validate_paletteE(34) to B(6);evaluate_contractD(26) to A(1);_parse_renderer_outputD(21) to A(2), behaviour-preserving with characterization tests written firstlib/andDreamcoderShell/extract()default output directory fixed in bash (SC2318)dreamcoder sync --helpno longer runs a real sync (arguments parsed first)SUPER+CTRL+arrows; the collision test has no exceptionsVerification
Sync output byte-identical for Dark and Light in an isolated worktree (900 tracked files + 20 HOME outputs);
radon ccno longer lists the three functions; ruff, ruff format, mypy --strict clean; full suites green. Note: thefix(shell): make extract()...commit also carries the palette/design-system characterization tests, which were staged concurrently by a second writer.Chain Context
main)pr/05-remove-night-profilepr/05-remove-night-profileChain Overview
Scope
sync.py/cli_handlers.py(separate design decision)Autonomy