test: close the review advisories from #90, #91 and #94 - #97
Merged
Merged
Conversation
…ests setSessionStorage overwrote a single module-level restore, so a test that swapped storage twice lost the first restore. Restores now stack and run newest first in afterEach. Refs #92. Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf
The test waited 260ms of real time; it now enables node:test mock timers and ticks past the idle timeout, so it is deterministic and instant. Refs #92. Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf
Keep the skip as the first statement, set apart from the page work, and stop restating the Chromium navigation rationale in two comments. Titles and tags are unchanged. Refs #93. Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf
The child inherited the whole parent env minus GITHUB_STEP_SUMMARY; it now gets only PATH plus what each test passes, so CI variables such as NODE_OPTIONS cannot leak in. Also make the table-row helper easier to read. Refs #95. Claude-Session: https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92, #93, #95.
Test-only changes: accumulating sessionStorage restores, mock timers for the idle teardown test, a tighter TERMINAL-003 guard (titles unchanged), and a hermetic child env for the lighthouse-summary tests. Unit 196/196, check, format and size budgets green locally.
https://claude.ai/code/session_01WKW6vNiCa8XkaAWAjPQLRf